public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Jörn Engel" <joern@logfs.org>,
	"Cyrill Gorcunov" <gorcunov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [x86] kernel/audit.c cleanup according to checkpatch.pl
Date: Thu, 3 Jan 2008 15:37:11 +0100	[thread overview]
Message-ID: <20080103143711.GA29606@elte.hu> (raw)
In-Reply-To: <1199370550.3697.79.camel@shinybook.infradead.org>


* David Woodhouse <dwmw2@infradead.org> wrote:

> On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote:
> > not to make a big issue out of this, but when was the last time you 
> > tried to grep this way:
> > 
> >   grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c
> 
> Not precisely that, but I've certainly had greps fail because people 
> have split up strings to meet the stupid 80-character "limit".

yes - but if you read my whole reply you'll see that i qualified it:

>> That's pretty much the only grep pattern that would break. People 
>> usually grep on the constant portion of the string, so breaking up a 
>>                                                       ^^^^^^^^^^^^^
>> line along a variable boundary is perfectly okay.
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

	Ingo

  reply	other threads:[~2008-01-03 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 11:19 [x86] kernel/audit.c cleanup according to checkpatch.pl Cyrill Gorcunov
2008-01-03 11:29 ` Jörn Engel
2008-01-03 11:46   ` Cyrill Gorcunov
2008-01-03 12:10     ` Tomas Carnecky
2008-01-03 12:16       ` Cyrill Gorcunov
2008-01-03 14:05   ` Ingo Molnar
2008-01-03 14:29     ` David Woodhouse
2008-01-03 14:37       ` Ingo Molnar [this message]
2008-01-03 14:37         ` David Woodhouse
2008-01-03 14:50           ` Cyrill Gorcunov
2008-01-03 14:57             ` David Woodhouse
2008-01-03 16:31               ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103143711.GA29606@elte.hu \
    --to=mingo@elte.hu \
    --cc=dwmw2@infradead.org \
    --cc=gorcunov@gmail.com \
    --cc=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox