* [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
@ 2007-12-20 10:09 Jesper Nilsson
2007-12-22 8:30 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Nilsson @ 2007-12-20 10:09 UTC (permalink / raw)
To: Clemens Koller, jesper.nilsson, Andrew Morton, Mikael Starvik,
linux-kernel
This is very old code, it hasn't changed since 2001 and
it is not used anywhere. Noticed by Clemens Koller.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
include/asm-cris/bitops.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/include/asm-cris/bitops.h b/include/asm-cris/bitops.h
index e2f49c2..75ea6e0 100644
--- a/include/asm-cris/bitops.h
+++ b/include/asm-cris/bitops.h
@@ -24,13 +24,6 @@
#include <linux/compiler.h>
/*
- * Some hacks to defeat gcc over-optimizations..
- */
-struct __dummy { unsigned long a[100]; };
-#define ADDR (*(struct __dummy *) addr)
-#define CONST_ADDR (*(const struct __dummy *) addr)
-
-/*
* set_bit - Atomically set a bit in memory
* @nr: the bit to set
* @addr: the address to start counting from
--
1.5.3.6.970.gd25430
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
2007-12-20 10:09 [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h Jesper Nilsson
@ 2007-12-22 8:30 ` Andrew Morton
2008-01-03 16:53 ` Jesper Nilsson
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-12-22 8:30 UTC (permalink / raw)
To: Jesper Nilsson; +Cc: Clemens Koller, Mikael Starvik, linux-kernel
On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
It's nice (and conventional) to prefix the patch title with the subsystem
name. So this one would become
Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
2007-12-22 8:30 ` Andrew Morton
@ 2008-01-03 16:53 ` Jesper Nilsson
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Nilsson @ 2008-01-03 16:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: Clemens Koller, Mikael Starvik, linux-kernel
On Sat, Dec 22, 2007 at 12:30:25AM -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> > Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
>
> It's nice (and conventional) to prefix the patch title with the subsystem
> name.
Sorry about that, will add that to my checklist.
> So this one would become
>
> Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h
>
> Thanks.
No, thank you. :-)
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-03 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-20 10:09 [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h Jesper Nilsson
2007-12-22 8:30 ` Andrew Morton
2008-01-03 16:53 ` Jesper Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).