From: David Miller <davem@davemloft.net>
To: matthias@goebl.net
Cc: linux-kernel@vger.kernel.org, kkeil@suse.de, kai.germaschewski@gmx.de
Subject: Re: [PATCH] isdn/i4l: Fix DLE handling for i4l-audio
Date: Fri, 04 Jan 2008 02:14:37 -0800 (PST) [thread overview]
Message-ID: <20080104.021437.238302886.davem@davemloft.net> (raw)
In-Reply-To: <20080103220003.GU19071@night.goebl.net>
From: Matthias Goebl <matthias@goebl.net>
Date: Thu, 3 Jan 2008 23:00:03 +0100
> --- linux-2.6.23.12.orig/drivers/isdn/i4l/isdn_tty.c 2007-12-22 21:13:49.000000000 +0100
> +++ linux-2.6.23.12/drivers/isdn/i4l/isdn_tty.c 2007-12-26 11:37:18.000000000 +0100
> @@ -85,6 +85,8 @@
> tty_insert_flip_char(tty, DLE, 0);
> tty_insert_flip_char(tty, *dp++, 0);
> }
> + if (*dp == DLE)
> + tty_insert_flip_char(tty, DLE, 0);
> last = *dp;
> } else {
> #endif
I'm not sure this part is correct.
Here, *dp will be assigned to 'last'.
The rest of the code (after the else block) then reads:
if (info->emu.mdmreg[REG_CPPP] & BIT_CPPP)
tty_insert_flip_char(tty, last, 0xFF);
else
tty_insert_flip_char(tty, last, TTY_NORMAL);
which should push that character out to the TTY.
With your change we will push a DLE out twice in such a case,
and that doesn't seem right.
next prev parent reply other threads:[~2008-01-04 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 22:00 [PATCH] isdn/i4l: Fix DLE handling for i4l-audio Matthias Goebl
2008-01-04 10:14 ` David Miller [this message]
2008-01-04 10:42 ` Matthias Goebl
2008-01-04 11:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104.021437.238302886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias@goebl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox