From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: mboton.lkml@gmail.com, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, yi.zhu@intel.com,
linville@tuxdriver.com
Subject: Re: [PATCH] iwlwifi: fix compilation warning in 'iwl-4965.c'
Date: Fri, 04 Jan 2008 14:31:12 -0800 (PST) [thread overview]
Message-ID: <20080104.143112.93580751.davem@davemloft.net> (raw)
In-Reply-To: <adaabnlme87.fsf@cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Fri, 04 Jan 2008 14:13:12 -0800
> > - "radiotap head [%d]\n",
> > + "radiotap head [%ld]\n",
> > skb_headroom(skb), sizeof(*iwl4965_rt));
>
> Actually I think the correct printf format for printing a size_t
> (coming here from sizeof foo) is "%zd". Otherwise you'll fix the
> warning on 64-bit targets but add a new warning on 32-bit targets.
Right.
next prev parent reply other threads:[~2008-01-04 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 22:05 [PATCH] iwlwifi: fix compilation warning in 'iwl-4965.c' Miguel Botón
2008-01-04 22:13 ` Roland Dreier
2008-01-04 22:31 ` David Miller [this message]
2008-01-04 22:15 ` Randy Dunlap
2008-01-04 22:15 ` Michael Buesch
2008-01-04 22:34 ` Miguel Botón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104.143112.93580751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mboton.lkml@gmail.com \
--cc=rdreier@cisco.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox