From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
olof@lixom.net, mpm@selenic.com
Subject: Re: [patch 1/2] move WARN_ON() out of line
Date: Fri, 4 Jan 2008 08:41:49 +0100 [thread overview]
Message-ID: <20080104074149.GC17447@elte.hu> (raw)
In-Reply-To: <477D52ED.7000403@linux.intel.com>
* Arjan van de Ven <arjan@linux.intel.com> wrote:
> This patch build on top of Olof's patch that introduces __WARN, and
> places the slowpath out of line. It also uses Ingo's suggestion to not
> use __FUNCTION__ but to use kallsyms to do the lookup; this saves a
> ton of extra space since gcc doesn't need to store the function string
> twice now:
>
> 3936367 833603 624736 5394706 525112 vmlinux.before
> 3917508 833603 624736 5375847 520767 vmlinux-slowpath
>
> 15Kb savings...
hey, cool!
Acked-by: Ingo Molnar <mingo@elte.hu>
i'm wondering how we could put this into x86.git to get it tested some
more. Olof's patch touches other architectures so it's not really
appropriate. Maybe a portion of Olof's patch could be applied to make
your patch apply cleanly?
Ingo
next prev parent reply other threads:[~2008-01-04 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 21:26 [patch 1/2] move WARN_ON() out of line Arjan van de Ven
2008-01-03 22:27 ` Matt Mackall
2008-01-04 7:41 ` Ingo Molnar [this message]
2008-01-04 16:00 ` Olof Johansson
2008-01-05 9:59 ` Adrian Bunk
2008-01-04 16:27 ` Olof Johansson
2008-01-05 13:16 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104074149.GC17447@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox