public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl
Date: Fri, 4 Jan 2008 14:23:28 +0100	[thread overview]
Message-ID: <20080104132328.GA27330@elte.hu> (raw)
In-Reply-To: <4d8e3fd30801040518q4e115efcoc8967e516fa365f1@mail.gmail.com>


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> > i.e. take the implicit assignment out of the condition. (it's easy 
> > to mistake it for '==' while reviewing the code and forgetting about 
> > the assignment's side-effect)
> 
> OK, thanks.
> 
> Is the following correct?
> 
> Before:
>  if (!(entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)))
> 
> After:
> entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)
> if (!entry)
> 
> BTW, how can i compile only the profile.c file?

make kernel/profile.o

> I would like to verify that my changes (now I'm at total: 2 errors, 1 
> warnings, 599 lines checked) doesn't impact on the compiled code?

check out:

 http://people.redhat.com/mingo/misc/q-size-obj-compare

which does a size and md5 comparison. (assuming your patch is in a quilt 
queue) But if you reorder symbols (due to the EXPORT_SYMBOL moving) the 
md5 might differ. (but size should still be the same)

	Ingo

  reply	other threads:[~2008-01-04 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 23:32 [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl Paolo Ciarrocchi
2008-01-03 23:37 ` Jesper Juhl
2008-01-04  8:34 ` Ingo Molnar
2008-01-04 11:18   ` Paolo Ciarrocchi
2008-01-04 13:07     ` Ingo Molnar
2008-01-04 13:18       ` Paolo Ciarrocchi
2008-01-04 13:23         ` Ingo Molnar [this message]
2008-01-04 13:43           ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080104132328.GA27330@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox