public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
To: andyw@uk.ibm.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Change a WARN message in checkpatch
Date: Fri, 4 Jan 2008 13:45:35 +0100	[thread overview]
Message-ID: <20080104134535.6689872a@paolo-desktop> (raw)

Hi Andy,
I just started using checkpatch and I was confused by the following WARN message:

	no space between function name and open parenthesis

I thought the probelm was that a space was missing while the truth is the opposite.

How about the following patch?


--- checkpatch.pl.old	2008-01-04 13:37:51.000000000 +0100
+++ checkpatch.pl	2008-01-04 13:37:24.000000000 +0100
@@ -1117,7 +1117,7 @@
 		while ($line =~ /($Ident)\s+\(/g) {
 			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
 		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
-				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+				WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
 # Check operator spacing.

             reply	other threads:[~2008-01-04 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-04 12:45 Paolo Ciarrocchi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-14 22:29 [PATCH] Change a WARN message in checkpatch Paolo Ciarrocchi
2008-01-28 14:56 ` Andy Whitcroft
2008-01-28 15:13   ` Paolo Ciarrocchi
2008-02-23 13:38     ` Paolo Ciarrocchi
2008-02-24 15:18       ` Benny Halevy
2008-02-24 18:14         ` Paolo Ciarrocchi
2008-02-25  3:29           ` Andy Whitcroft
2008-02-25  5:47             ` Benny Halevy
2008-02-25  6:51             ` Paolo Ciarrocchi
2008-02-25 10:53               ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080104134535.6689872a@paolo-desktop \
    --to=paolo.ciarrocchi@gmail.com \
    --cc=andyw@uk.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox