From: Sam Ravnborg <sam@ravnborg.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Al Boldi <a1426z@gawab.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Sat, 5 Jan 2008 21:54:24 +0100 [thread overview]
Message-ID: <20080105205424.GA10191@uranus.ravnborg.org> (raw)
In-Reply-To: <20080105203123.GA7797@flint.arm.linux.org.uk>
On Sat, Jan 05, 2008 at 08:31:24PM +0000, Russell King wrote:
> On Sat, Jan 05, 2008 at 08:20:00PM +0100, Sam Ravnborg wrote:
> > On Sat, Jan 05, 2008 at 06:42:52PM +0300, Al Boldi wrote:
> > >
> > > From: David Brownell <david-b@pacbell.net>
> > >
> > > Source "drivers/usb/gadget/Kconfig" for ARCH=arm.
> > >
> > >
> > > Cc: David Brownell <david-b@pacbell.net>
> > > Cc: Greg KH <greg@kroah.com>
> > > Cc: Andrew Morton <akpm@linux-foundation.org>
> > > Signed-off-by: Al Boldi <a1426z@gawab.com>
> > >
> > > ---
> > >
> > > --- 23.a/arch/arm/Kconfig
> > > +++ 23.b/arch/arm/Kconfig
> > > @@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
> > >
> > > source "drivers/usb/Kconfig"
> > >
> > > +source "drivers/usb/gadget/Kconfig"
> > > +
> > > source "drivers/mmc/Kconfig"
> > >
> > > source "drivers/rtc/Kconfig"
> >
> > What is preventing ARM from using drivers/Kconfig?
> > That a better fix IMO.
>
> Not everything in drivers/ is suitable for every ARM configuration. It
> was felt at the time better for ARM to remain separate because people
> didn't want to pollute drivers/Kconfig with the ARM specific conditionals.
>
Today we would have used HAVE_ for the problematic parts and thus
it would have been easy to not select what ARM does not support.
But unfortunately thats not how it got designed.
It would be nice to revist one day to see how much is actually needed
to cleanly supprt ARM in drivers/Kconfig.
Sam
next prev parent reply other threads:[~2008-01-05 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 15:42 [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm Al Boldi
2008-01-05 18:46 ` David Brownell
2008-01-05 19:20 ` Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm] Sam Ravnborg
2008-01-05 20:31 ` Russell King
2008-01-05 20:54 ` Sam Ravnborg [this message]
2008-01-05 21:09 ` Russell King
2008-01-05 22:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080105205424.GA10191@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=a1426z@gawab.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox