From: "Miguel Botón" <mboton.lkml@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] x86: little fix in 'include/asm-x86/topology.h'
Date: Sat, 5 Jan 2008 21:25:59 +0100 [thread overview]
Message-ID: <200801052126.00016.mboton@gmail.com> (raw)
In-Reply-To: <20080105150944.GA9595@elte.hu>
On Saturday 05 January 2008 16:09:44 Ingo Molnar wrote:
> * Miguel Botón <mboton.lkml@gmail.com> wrote:
> > Before 'topology_32.h' and 'topology_64.h' were unified, topology
> > defines in a X86_64 kernel were declared if CONFIG_SMP was enabled.
> > Now, post unification, these same defines in a X86_64 kernel are only
> > being declared if CONFIG_NUMA and CONFIG_SMP are enabled.
> >
> > This, for example, breaks 'perfmon_amd64.c' compilation.
> >
> > This patch defines ENABLE_TOPO_DEFINE if this is a X86_64 kernel and
> > we have SMP support enabled.
>
> hm, do you have a .config that fails to build?
>
> Ingo
I had a .config (I deleted it) that fails to build *but* using the tree from
http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=summary
The problem was that CONFIG_NUMA wasn't defined so ENABLE_TOPO_DEFINE wasn't
defined too and then we get an error about an implicit declaration
of 'topology_physical_package_id'.
--
Miguel Botón
prev parent reply other threads:[~2008-01-05 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 22:04 [PATCH] x86: little fix in 'include/asm-x86/topology.h' Miguel Botón
2008-01-05 15:09 ` Ingo Molnar
2008-01-05 20:25 ` Miguel Botón [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801052126.00016.mboton@gmail.com \
--to=mboton.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox