Re: [PATCH] x86: ioport_{32|64}.c unification

["Miguel Botón" <mboton.lkml@gmail.com>]

On Sunday 06 January 2008 01:47:47 Arnd Bergmann wrote:
> This #ifdef overload could probably be avoided if you just move
> the body of this function into an extra place and do
>
> static int do_iopl(unsigned int level, unsigned long *flags)
> {
>         unsigned int old = (*flags >> 12) & 3;
> 	...
>         *flags = (*flags & ~X86_EFLAGS_IOPL) | (level << 12);;
> }
>
> #ifdef CONFIG_X86_32
> asmlinkage long sys_iopl(unsigned long regsp)
> {
> 	/* why is this volatle anyway? */
> 	volatile struct pt_regs *regs = (struct pt_regs *)&regsp;
> 	unsigned int level = regs->bx;
> 	return do_iopl(regs->bx, &regs->flags);
> }
> #else
> asmlinkage long sys_iopl(unsigned int level, struct pt_regs *regs)
> {
> 	return do_iopl(level, &regs->flags);
> }
> #endif
>
> 	Arnd <><

I agree. I'll send the a proper patch soon.

-- 
	Miguel Botón