public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Miguel Botón" <mboton.lkml@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
	linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@elte.hu>,
	tglx@linutronix.de
Subject: Re: [PATCH] x86: ioport_{32|64}.c unification
Date: Sun, 6 Jan 2008 02:20:45 +0100	[thread overview]
Message-ID: <200801060220.45669.mboton@gmail.com> (raw)
In-Reply-To: <200801060147.48185.arnd@arndb.de>

I just realize that in some cases 'regs->flags' is a long instead of an 
unsigned long so... this would be a proper solution?

static long do_iopl(unsigned int level, long *flags)
{
	...
}

#ifdef CONFIG_X86_32
asmlinkage long sys_iopl(unsigned long regsp)
{
	volatile struct pt_regs *regs = (struct pt_regs *)&regsp;
	unsigned int level = regs->bx;
#else
asmlinkage long sys_iopl(unsigned int level, struct pt_regs *regs)
{
#endif
	return do_iopl(level, (long *)&regs->flags);
}

Or maybe would be better if 'do_iopl' prototype is:

static long do_iopl(unsigned int level, struct pt_regs *regs);

-- 
	Miguel Botón

  parent reply	other threads:[~2008-01-06  1:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05 23:59 [PATCH] x86: ioport_{32|64}.c unification Miguel Botón
2008-01-06  0:47 ` Arnd Bergmann
2008-01-06  1:00   ` Miguel Botón
2008-01-06  1:20   ` Miguel Botón [this message]
2008-01-06  5:55     ` Valdis.Kletnieks
2008-01-06 15:30       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801060220.45669.mboton@gmail.com \
    --to=mboton.lkml@gmail.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox