public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] profile: further Codying Style fixes
Date: Sun, 6 Jan 2008 11:25:44 +0100	[thread overview]
Message-ID: <20080106102544.GB11765@elte.hu> (raw)
In-Reply-To: <20080104152858.1fb9b868@paolo-desktop>


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> Further codying style fixes on top of:
> http://marc.info/?l=linux-kernel&m=119940325306693&w=2

thanks, applied.

> 1 Warning is still not killed:
> WARNING: externs should be avoided in .c files
> #509: FILE: profile.c:509:
> +       extern int setup_profiling_timer(unsigned int multiplier);
> 
> I don't know how to fix it :-/

simply move that line to include/linux/profile.h. (no need to preserve 
the CONFIG_SMP - on !SMP the function prototype line will not be used)

	Ingo

  reply	other threads:[~2008-01-06 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-04 14:28 [PATCH] profile: further Codying Style fixes Paolo Ciarrocchi
2008-01-06 10:25 ` Ingo Molnar [this message]
2008-01-06 10:58   ` Paolo Ciarrocchi
2008-01-06 13:46     ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-01-04 14:25 Paolo Ciarrocchi
2008-01-04 17:13 ` Sam Ravnborg
2008-01-04 17:18   ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080106102544.GB11765@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox