Re: [PATCH] drivers/dma/ioat_dma.c: inlining failed

[Adrian Bunk <bunk@kernel.org>]

On Sun, Jan 06, 2008 at 01:57:23PM +0100, Mariusz Kozlowski wrote:
> Hello,
> 
> > > >After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's 
> > > >git tree gaves following compiliation error with gcc-3.4.6. 
> > > >Following patch solves this issue for me;
> > > >
> > > >
> > > >[...]
> > > >  CC [M]  drivers/dma/ioat.o
> > > >  CC [M]  drivers/dma/ioat_dma.o
> > > >drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
> > > >drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining 
> > > >failed in call to '__ioat1_dma_memcpy_issue_pending': function 
> > > >body not available
> > > >drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
> > > >make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
> > > >make[1]: *** [drivers/dma] Hata 2
> > > >make: *** [drivers] Hata 2
> > > >
> > > >Signed-off-by: S.__a__lar Onur <caglar@pardus.org.tr>
> > > [...]
> > > 
> > > Yep.  I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree.  See http://lkml.org/lkml/2007/11/16/336
> > > 
> > 
> > Nobody told me that it fixed anything serious so I had it scheduled for
> > 2.6.25.  I'll move it up.
> 
> BTW. It's still not there. Latest Linus linux-2.6 git tree with gcc-3.4.6:
> 
>   CC [M]  drivers/dma/ioat_dma.o
> drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
> drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available
> drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
> make[2]: *** [drivers/dma/ioat_dma.o] Error 1
> make[1]: *** [drivers/dma] Error 2
> make: *** [drivers] Error 2

The fix is in Linus' tree since 17 Dec 2007, and the line numbers in 
your error messages also don't make sense in the current tree.

Is there any problem with your local copy of the tree?

> Regards,
> 
> 	Mariusz

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed