Re: [PATCH] profile: further Codying Style fixes

Ingo Molnar
2008-01-06T10:26:16Z

* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> Further codying style fixes on top of:
> http://marc.info/?l=linux-kernel&m=119940325306693&w=2

thanks, applied.

> 1 Warning is still not killed:
> WARNING: externs should be avoided in .c files
> #509: FILE: profile.c:509:
> + extern int setup_profiling_timer(unsigned int multiplier);
>
> I don't know how to fix it :-/

simply move that line to include/linux/profile.h. (no need to preserve
the CONFIG_SMP - on !SMP the function prototype line will not be used)

Ingo