Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

James Bottomley
2008-01-02T16:46:36Z

On Wed, 2008-01-02 at 17:25 +0100, Ingo Molnar wrote:
> revert commit:
>
> commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d
> Author: Matthew Wilcox <matthew@wil.cx>
> Date: Tue Sep 25 12:42:04 2007 -0400
>
> [SCSI] Get rid of scsi_cmnd->done
>
> this is a supposed-to-be-cleanup commit, but apparently it causes
> regressions:
>
> Bug 9370 - v2.6.24-rc2-409-g9418d5d: attempt to access beyond end of device
> http://bugzilla.kernel.org/show_bug.cgi?id=9370
>
> this patch should be reintroduced in a more split-up form to make
> testing of it easier.

I disagree with this. We only have one reporter of a problem and it
appears to be some type of obscure interaction with pktdvd which no-one
can track down (although it's not really helped by the reporter not
being very responsive).

The correct thing to do is root cause the problem and fix it at source,
since it's very likely that this is a pre-existing bug that was simply
uncovered by the patch you're recommending we revert.

Unfortunately, I suspect it won't get fixed until someone else actually
manages to reproduce it (which I haven't been able to so far).

James