Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

James Bottomley
2008-01-06T14:05:19Z

On Sat, 2008-01-05 at 19:43 -0800, Linus Torvalds wrote:
> This all still leaves the question unanswered why that commit
> 6f5391c283d7fdcf24bf40786ea79061919d1e1d changed any behaviour at
> all.
> Because the thing that Peter is describing has nothing to do with any
> low-level drivers what-so-ever.

It isn't even a secondary effect like I thought. This commit genuinely
didn't have anything to do with the bug, it was purely accidental. It
came about because if you look at the reporter's recipe to reproduce,
which all of us tried without success, it's missing several steps. To
get the bug, these steps must have been done somehow, but I bet by pure
chance they weren't when reverting
6f5391c283d7fdcf24bf40786ea79061919d1e1d which led to wrongly fingering
this commit.

Now, if only someone who understood the mechanics of what the commit was
doing tried to stop you reverting it we could have saved a lot of
trouble ...

James