Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

Matthew Wilcox
2008-01-02T20:18:46Z

On Wed, Jan 02, 2008 at 11:57:10AM -0800, Linus Torvalds wrote:
> On Wed, 2 Jan 2008, Matthew Wilcox wrote:
> >
> > sd_done and sr_done are called for REQ_TYPE_FS -- if the request comes
> > in through one of the SG interfaces, we call scsi_setup_blk_pc_cmnd()
> > which sets the ->done callback to scsi_blk_pc_done.
>
> Why do you think that REQ_TYPE_BLOCK_PC has anything to do with SG?
>
> It has *nothing* to do with SG, and anybody who uses SG in this day and
> age on a block device is just crazy.
>
> The way you do generic SCSI commands (on perfectly normal block device
> nodes) is using the SCSI ioctl() interfaces. That's how you are supposed
> to do things like burn DVD's or do any kind of special ops.
>
> So REQ_TYPE_BLOCK_PC does quite commonly happen on perfectly regular block
> devices, it's how all commands that aren't pure reads or writes done by
> the kernel behave.

I spoke imprecisely; a raw command one through SG or ioctl is
REQ_TYPE_BLOCK_PC and did not go through sd_done or sr_done before this
patch.

> If you actually use /dev/sg*, you will be using the SG driver, and if you
> don't want that to have a ->done callback, then just set "done" to NULL
> for sg_driver.

Unless you think that we should see different behaviour when using
/dev/sg* and /dev/sd*, the aspect of the patch you criticised was
correct.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."