Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

Matthew Wilcox
2008-01-02T20:53:31Z

On Wed, Jan 02, 2008 at 12:49:32PM -0800, Linus Torvalds wrote:
> Maybe it's not that one suspicious test. Maybe it's somethign else. But
> that commit was confirmed to break something, almost two months ago. You
> guys seem to be in denial, and saying "it didn't change anything".
>
> And no, waiting for more reporters when one reporter has already narrowed
> it down to the exact (smallish) commit, is simply not good. Either you can
> fix it by looking at the source, or it gets reverted.
>
> I was hoping somebody in SCSI-land would actually look at the commit and
> try to find out what's wrong, instead of all of you apparently trying to
> say "nothing is wrong".

I've spent about a week of time looking at it over the last couple of
months. I haven't been able to figure it out. That's why I'm calling
for it to be reverted, not because I'm "in denial".

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."