From: Olof Johansson <olof@lixom.net>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
heiko.carstens@de.ibm.com, mingo@elte.hu, mpm@selenic.com
Subject: Re: [patch 2/5] move WARN_ON() out of line
Date: Sun, 6 Jan 2008 13:40:05 -0600 [thread overview]
Message-ID: <20080106194005.GA7992@lixom.net> (raw)
In-Reply-To: <20080105190959.1880f1c4@laptopd505.fenrus.org>
On Sat, Jan 05, 2008 at 07:09:59PM -0800, Arjan van de Ven wrote:
> From: Arjan van de Ven <arjan@linux.intel.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Olof Johansson <olof@lixom.net>
> Acked-by: Matt Meckall <mpm@selenic.com>
>
> A quick grep shows that there are currently 1145 instances of WARN_ON
> in the kernel. Currently, WARN_ON is pretty much entirely inlined,
> which makes it hard to enhance it without growing the size of the kernel
> (and getting Andrew unhappy).
>
> This patch build on top of Olof's patch that introduces __WARN,
> and places the slowpath out of line. It also uses Ingo's suggestion
> to not use __FUNCTION__ but to use kallsyms to do the lookup;
> this saves a ton of extra space since gcc doesn't need to store the function
> string twice now:
>
> 3936367 833603 624736 5394706 525112 vmlinux.before
> 3917508 833603 624736 5375847 520767 vmlinux-slowpath
>
> 15Kb savings...
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Olof Johansson <olof@lixom.net>
next prev parent reply other threads:[~2008-01-06 19:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 3:07 [patch 0/5] enhance WARN_ON series Arjan van de Ven
2008-01-06 3:08 ` [patch 1/5] Introduce __WARN() Arjan van de Ven
2008-01-06 11:44 ` Richard Knutsson
2008-01-06 15:42 ` Arjan van de Ven
2008-01-06 16:09 ` Richard Knutsson
2008-01-06 17:10 ` Arjan van de Ven
2008-01-06 17:42 ` Richard Knutsson
2008-01-06 3:09 ` [patch 2/5] move WARN_ON() out of line Arjan van de Ven
2008-01-06 19:40 ` Olof Johansson [this message]
2008-01-06 3:10 ` [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON() Arjan van de Ven
2008-01-06 10:04 ` David Woodhouse
2008-01-07 17:31 ` Valdis.Kletnieks
2008-01-06 3:11 ` [patch 4/5] bugh-remove-have_arch_bug--have_arch_warn Arjan van de Ven
2008-01-06 3:12 ` [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON Arjan van de Ven
2008-01-06 11:16 ` Benjamin Herrenschmidt
2008-01-06 14:46 ` Olof Johansson
2008-01-06 9:26 ` [patch 0/5] enhance WARN_ON series Ingo Molnar
2008-01-06 20:22 ` [PATCH] Add bug/warn marker to generic report_bug() Olof Johansson
2008-01-06 21:38 ` Arjan van de Ven
2008-01-07 1:22 ` Olof Johansson
2008-01-07 4:55 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106194005.GA7992@lixom.net \
--to=olof@lixom.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox