From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: david@fries.net, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] system timer: fix crash in <100Hz system timer
Date: Mon, 7 Jan 2008 16:09:51 -0800 [thread overview]
Message-ID: <20080107160951.5b63d5dc.akpm@linux-foundation.org> (raw)
In-Reply-To: <4782BAED.7060102@zytor.com>
On Mon, 07 Jan 2008 15:51:09 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:
> >> + do_div(x, HZ / USER_HZ);
> >> + #endif
> >> #else
> >> /*
> >> * There are better ways that don't overflow early,
> >
> > Alas, I get 100% rejects due to conflicting changes from Peter's
> > avoid-overflows-in-kernel-timec.patch.
> >
> > Peter, did that patch propagate this failure, or might it have happily
> > fixed it?
> >
>
> My patch doesn't touch any of these functions, nor touches any code
> within 70 lines of this patch -- the last line touched is line 478 --
> and doesn't touch linux/acct.h at all, so how could it cause a conflict?
oop, sorry, it was the mime-mess-mangles-everything problem and I failed to
spot it.
> But no, it doesn't fix this particular problem, even if using a similar
> technique might very well be a better way to do this kind of conversion.
OK.
next prev parent reply other threads:[~2008-01-08 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 22:16 [PATCH] system timer: fix crash in <100Hz system timer David Fries
2008-01-07 23:36 ` Andrew Morton
2008-01-07 23:51 ` H. Peter Anvin
2008-01-08 0:09 ` Andrew Morton [this message]
2008-01-09 7:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107160951.5b63d5dc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@fries.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox