[PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[Paolo Ciarrocchi]

Fix one error reported by checkpatch,
it now reports:

total: 0 errors, 0 warnings, 42 lines checked

Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
 arch/x86/ia32/audit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/ia32/audit.c b/arch/x86/ia32/audit.c
index 91b7b59..5d7b381 100644
--- a/arch/x86/ia32/audit.c
+++ b/arch/x86/ia32/audit.c
@@ -27,7 +27,7 @@ unsigned ia32_signal_class[] = {

 int ia32_classify_syscall(unsigned syscall)
 {
-       switch(syscall) {
+       switch (syscall) {
        case __NR_open:
                return 2;
        case __NR_openat:
--
1.5.4.rc2.17.g257f




-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

Re: [PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[Ingo Molnar]

* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

>  int ia32_classify_syscall(unsigned syscall)
>  {
> -       switch(syscall) {
> +       switch (syscall) {
>         case __NR_open:
>                 return 2;
>         case __NR_openat:

this patch has whitespace damage. (tabs got converted to spaces)

i fixed this up, but the other patches in your queue are corrupted too, 
they have linewraps and tabs->spaces problems as well.

also, please use unique subjects for your patches. Instead of:

  Subject: Codying style fixes in ./arch/x86/ia32

use:

  Subject: x86: coding style fixes in arch/x86/ia32/audit.c

(also please keep them lower case)

	Ingo

Re: [PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[Paolo Ciarrocchi]

On Jan 8, 2008 11:20 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
>
> >  int ia32_classify_syscall(unsigned syscall)
> >  {
> > -       switch(syscall) {
> > +       switch (syscall) {
> >         case __NR_open:
> >                 return 2;
> >         case __NR_openat:
>
> this patch has whitespace damage. (tabs got converted to spaces)
>
> i fixed this up, but the other patches in your queue are corrupted too,
> they have linewraps and tabs->spaces problems as well.

:-/ Sorry about that, I fwed the patch queue with gmail.

> also, please use unique subjects for your patches. Instead of:
>
>   Subject: Codying style fixes in ./arch/x86/ia32
>
> use:
>
>   Subject: x86: coding style fixes in arch/x86/ia32/audit.c
>
> (also please keep them lower case)

OK, will do that when I'll back home.

And I'll send the patch queue using a proper MUA :-)

Thanks.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

Re: [PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[Ingo Molnar]

* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> > i fixed this up, but the other patches in your queue are corrupted 
> > too, they have linewraps and tabs->spaces problems as well.
> 
> :-/ Sorry about that, I fwed the patch queue with gmail.

no problem.

> >   Subject: x86: coding style fixes in arch/x86/ia32/audit.c
> >
> > (also please keep them lower case)
> 
> OK, will do that when I'll back home.
> 
> And I'll send the patch queue using a proper MUA :-)

btw., there's "quilt mail" or "git-send-email" that can send patchsets 
as well, it's much easier than sending patches manually.

	Ingo

Re: [PATCH 1/5] Codying style fixes in ./arch/x86/ia32

[Paolo Ciarrocchi]

On Jan 8, 2008 11:28 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
>
> > > i fixed this up, but the other patches in your queue are corrupted
> > > too, they have linewraps and tabs->spaces problems as well.
> >
> > :-/ Sorry about that, I fwed the patch queue with gmail.
>
> no problem.
>
> > >   Subject: x86: coding style fixes in arch/x86/ia32/audit.c
> > >
> > > (also please keep them lower case)
> >
> > OK, will do that when I'll back home.
> >
> > And I'll send the patch queue using a proper MUA :-)
>
> btw., there's "quilt mail" or "git-send-email" that can send patchsets
> as well, it's much easier than sending patches manually.

I'll give git-send-email a try, since I started using git rebase -i I
didn't feel the need
of quilt/stgit but I should learn how to use these tools as well :-)

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/