Re: [patch] split MMC_CAP_4_BIT_DATA

[Mike Frysinger <vapier.adi@gmail.com>]

On Tuesday 08 January 2008 14:21:57 Pierre Ossman wrote:
> Mike Frysinger <vapier.adi@gmail.com> wrote:
> > The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do
> > 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO.  Thus the current
> > convention of MMC_CAP_4_BIT_DATA meaning "your host controller can do
> > 1-bit or 4-bit for all modes" is insufficient for our needs.  The
> > attached patch splits MMC_CAP_4_BIT_DATA into MMC_CAP_MMC_4_BIT_DATA and
> > MMC_CAP_SD_4_BIT_DATA and updates all host controllers to include these
> > in their caps and then changes existing code to check the new defines. 
> > At the moment, SD/SDIO are lumped into MMC_CAP_SD_4_BIT_DATA ... should I
> > bother with splitting that into SD and SDIO as well while I'm doing this
> > ?
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> I fail to see why you need to split MMC and SD. Could you elaborate why the
> controller won't work with MMC cards? I haven't seen any differences from
> SD.

i dont understand what's confusing.  the Blackfin on chip host controller only 
supports 1-bit MMC, but it supports 4-bit SD/SDIO.  this is a fact.  while it 
may be a stupid decision, it is what it is, and i need the framework made 
more flexible in order to get the Blackfin driver merged cleanly.  we do 
software for hardware, we dont do hardware.
-mike