From: Theodore Tso <tytso@mit.edu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, apw@shadowen.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] Deprecate checkpatch.pl --file
Date: Tue, 8 Jan 2008 13:20:48 -0500 [thread overview]
Message-ID: <20080108182048.GM27800@mit.edu> (raw)
In-Reply-To: <1199815279.1756.35.camel@imap.mvista.com>
On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote:
> > It is a simple pain/benefit issue.
> > Fixing the 25 errors and 13 warnings in kernel/profile.c may look
> > like an easy task but then we put additional burden on the 10 people
> > that have patches pending for this file.
>
> This goes for all patches on kernel/profile.c tho .. If I make a big mod
> to kernel/profile.c, that will screw up anyone else who has patches for
> that file..
Obviously, but why make it worse? And what's more important? A
"clean tree" (especially when some of the things that checkpatch.pl
flag are arbitrary and Not All That Important), or wasting developers'
time invalidating potentially huge number of patches thanks to cleanup
patches?
- Ted
next prev parent reply other threads:[~2008-01-08 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:14 [PATCH] Deprecate checkpatch.pl --file Andi Kleen
2008-01-08 16:50 ` Daniel Walker
2008-01-08 17:53 ` Sam Ravnborg
2008-01-08 18:01 ` Daniel Walker
2008-01-08 18:20 ` Theodore Tso [this message]
2008-01-08 18:33 ` Daniel Walker
2008-01-08 19:21 ` Sam Ravnborg
2008-01-08 19:27 ` Andi Kleen
2008-01-08 20:19 ` Daniel Walker
2008-01-08 21:14 ` Theodore Tso
2008-01-08 21:50 ` Daniel Walker
2008-01-08 20:27 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108182048.GM27800@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@shadowen.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox