Re: [patch 05/19] split LRU lists into anon & file sets

Lee Schermerhorn
2008-01-11T15:58:34Z

On Fri, 2008-01-11 at 10:42 -0500, Rik van Riel wrote:
> On Fri, 11 Jan 2008 15:24:34 +0900
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
> > below patch is a bit cleanup proposal.
> > i think LRU_FILE is more clarify than "/2".
> >
> > What do you think it?
>
> Thank you for the cleanup, your version looks a lot nicer.
> I have applied your patch to my series.
>

Rik:

I think we also want to do something like:

- BUILD_BUG_ON(LRU_INACTIVE_FILE != 2 || LRU_ACTIVE_FILE != 3);
+ BUILD_BUG_ON(LRU_INACTIVE_FILE != 2 || LRU_ACTIVE_FILE != 3 ||
+ NR_LRU_LISTS > 6);

Then we'll be warned if future change might break our implicit
assumption that any lru_list value with '0x2' set is a file lru.

Lee