From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Hellwig <hch@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <tim.bird@am.sony.com>, Sam Ravnborg <sam@ravnborg.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [RFC PATCH 07/22 -v2] tracer add debugfs interface
Date: Wed, 09 Jan 2008 18:29:21 -0500 [thread overview]
Message-ID: <20080109233043.337688449@goodmis.org> (raw)
In-Reply-To: 20080109232914.676624725@goodmis.org
[-- Attachment #1: mcount-tracer-debugfs.patch --]
[-- Type: text/plain, Size: 3672 bytes --]
This patch adds an interface into debugfs.
/debugfs/tracing/ctrl
echoing 1 into the ctrl file turns on the tracer,
and echoing 0 turns it off.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
lib/tracing/tracer.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++-
lib/tracing/tracer.h | 1
2 files changed, 87 insertions(+), 1 deletion(-)
Index: linux-compile-i386.git/lib/tracing/tracer.c
===================================================================
--- linux-compile-i386.git.orig/lib/tracing/tracer.c 2008-01-09 14:10:46.000000000 -0500
+++ linux-compile-i386.git/lib/tracing/tracer.c 2008-01-09 15:17:43.000000000 -0500
@@ -15,6 +15,8 @@
#include <linux/init.h>
#include <linux/linkage.h>
#include <linux/seq_file.h>
+#include <linux/debugfs.h>
+#include <linux/uaccess.h>
#include <linux/mcount.h>
#include "tracer.h"
@@ -71,6 +73,89 @@ static notrace void trace_function(const
raw_local_irq_restore(flags);
}
+#ifdef CONFIG_DEBUG_FS
+static int mctracer_open_generic(struct inode *inode, struct file *filp)
+{
+ filp->private_data = inode->i_private;
+ return 0;
+}
+
+
+static ssize_t mctracer_ctrl_read(struct file *filp, char __user *ubuf,
+ size_t cnt, loff_t *ppos)
+{
+ struct mctracer_trace *tr = filp->private_data;
+ char buf[16];
+ int r;
+
+ r = sprintf(buf, "%ld\n", tr->ctrl);
+ return simple_read_from_buffer(ubuf, cnt, ppos,
+ buf, r);
+}
+
+static ssize_t mctracer_ctrl_write(struct file *filp,
+ const char __user *ubuf,
+ size_t cnt, loff_t *ppos)
+{
+ struct mctracer_trace *tr = filp->private_data;
+ long val;
+ char buf[16];
+
+ if (cnt > 15)
+ cnt = 15;
+
+ if (copy_from_user(&buf, ubuf, cnt))
+ return -EFAULT;
+
+ buf[cnt] = 0;
+
+ val = !!simple_strtoul(buf, NULL, 10);
+
+ if (tr->ctrl ^ val) {
+ if (val)
+ register_mcount_function(trace_function);
+ else
+ clear_mcount_function();
+ tr->ctrl = val;
+ }
+
+ filp->f_pos += cnt;
+
+ return cnt;
+}
+
+static struct file_operations mctracer_ctrl_fops = {
+ .open = mctracer_open_generic,
+ .read = mctracer_ctrl_read,
+ .write = mctracer_ctrl_write,
+};
+
+static void mctrace_init_debugfs(void)
+{
+ struct dentry *d_mctracer;
+ struct dentry *entry;
+
+ d_mctracer = debugfs_create_dir("tracing", NULL);
+ if (!d_mctracer) {
+ pr_warning("Could not create debugfs directory mctracer\n");
+ return;
+ }
+
+ entry = debugfs_create_file("ctrl", 0644, d_mctracer,
+ &mctracer_trace, &mctracer_ctrl_fops);
+ if (!entry)
+ pr_warning("Could not create debugfs 'ctrl' entry\n");
+}
+#else /* CONFIG_DEBUG_FS */
+static void mctrace_init_debugfs(void)
+{
+ /*
+ * No way to turn on or off the trace function
+ * without debugfs, so we just turn it on.
+ */
+ register_mcount_function(trace_function);
+}
+#endif /* CONFIG_DEBUG_FS */
static notrace int page_order(const unsigned long size)
{
@@ -106,7 +191,7 @@ static notrace int mctracer_alloc_buffer
size, MCTRACER_NR_ENTRIES, MCTRACER_ENTRY_SIZE);
pr_info(" actual entries %ld\n", mctracer_trace.entries);
- register_mcount_function(trace_function);
+ mctrace_init_debugfs();
return 0;
Index: linux-compile-i386.git/lib/tracing/tracer.h
===================================================================
--- linux-compile-i386.git.orig/lib/tracing/tracer.h 2008-01-09 14:10:46.000000000 -0500
+++ linux-compile-i386.git/lib/tracing/tracer.h 2008-01-09 15:17:41.000000000 -0500
@@ -13,6 +13,7 @@ struct mctracer_trace {
void *trace[NR_CPUS];
unsigned long trace_idx[NR_CPUS];
unsigned long entries;
+ long ctrl;
atomic_t cnt;
atomic_t disabled[NR_CPUS];
atomic_t underrun[NR_CPUS];
--
next prev parent reply other threads:[~2008-01-09 23:37 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 23:29 [RFC PATCH 00/22 -v2] mcount and latency tracing utility -v2 Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 01/22 -v2] Add basic support for gcc profiler instrumentation Steven Rostedt
2008-01-10 18:19 ` Jan Kiszka
2008-01-10 19:54 ` Steven Rostedt
2008-01-10 23:02 ` Steven Rostedt
2008-01-10 18:28 ` Sam Ravnborg
2008-01-10 19:10 ` Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 02/22 -v2] Annotate core code that should not be traced Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 03/22 -v2] x86_64: notrace annotations Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 04/22 -v2] add notrace annotations to vsyscall Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 05/22 -v2] add notrace annotations for NMI routines Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 06/22 -v2] mcount based trace in the form of a header file library Steven Rostedt
2008-01-09 23:29 ` Steven Rostedt [this message]
2008-01-09 23:29 ` [RFC PATCH 08/22 -v2] mcount tracer output file Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 09/22 -v2] mcount tracer show task comm and pid Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 10/22 -v2] Add a symbol only trace output Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 11/22 -v2] Reset the tracer when started Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 12/22 -v2] separate out the percpu date into a percpu struct Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays Steven Rostedt
2008-01-10 0:00 ` john stultz
2008-01-10 0:09 ` Steven Rostedt
2008-01-10 19:54 ` Tony Luck
2008-01-10 20:15 ` Steven Rostedt
2008-01-10 20:41 ` john stultz
2008-01-10 20:29 ` john stultz
2008-01-10 20:42 ` Mathieu Desnoyers
2008-01-10 21:25 ` john stultz
2008-01-10 22:00 ` Mathieu Desnoyers
2008-01-10 22:40 ` Steven Rostedt
2008-01-10 22:51 ` john stultz
2008-01-10 23:05 ` john stultz
2008-01-10 21:33 ` [RFC PATCH 13/22 -v2] handle accurate time keeping over longdelays Luck, Tony
2008-01-10 0:19 ` [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays john stultz
2008-01-10 0:25 ` Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 14/22 -v2] time keeping add cycle_raw for actual incrementation Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 15/22 -v2] initialize the clock source to jiffies clock Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 16/22 -v2] add get_monotonic_cycles Steven Rostedt
2008-01-10 3:28 ` Daniel Walker
2008-01-15 21:46 ` Mathieu Desnoyers
2008-01-15 22:01 ` Steven Rostedt
2008-01-15 22:03 ` Steven Rostedt
2008-01-15 22:08 ` Mathieu Desnoyers
2008-01-16 1:38 ` Steven Rostedt
2008-01-16 3:17 ` Mathieu Desnoyers
2008-01-16 13:17 ` Steven Rostedt
2008-01-16 14:56 ` Mathieu Desnoyers
2008-01-16 15:06 ` Steven Rostedt
2008-01-16 15:28 ` Mathieu Desnoyers
2008-01-16 15:58 ` Steven Rostedt
2008-01-16 17:00 ` Mathieu Desnoyers
2008-01-16 17:49 ` Mathieu Desnoyers
2008-01-16 19:43 ` Steven Rostedt
2008-01-16 20:17 ` Mathieu Desnoyers
2008-01-16 20:45 ` Tim Bird
2008-01-16 20:49 ` Steven Rostedt
2008-01-17 20:08 ` Steven Rostedt
2008-01-17 20:37 ` Frank Ch. Eigler
2008-01-17 21:03 ` Steven Rostedt
2008-01-18 22:26 ` Mathieu Desnoyers
2008-01-18 22:49 ` Steven Rostedt
2008-01-18 23:19 ` Mathieu Desnoyers
2008-01-19 3:36 ` Frank Ch. Eigler
2008-01-19 3:55 ` Steven Rostedt
2008-01-19 4:23 ` Frank Ch. Eigler
2008-01-19 15:29 ` Mathieu Desnoyers
2008-01-19 3:32 ` Frank Ch. Eigler
2008-01-16 18:01 ` Tim Bird
2008-01-16 22:36 ` john stultz
2008-01-16 22:51 ` john stultz
2008-01-16 23:33 ` Steven Rostedt
2008-01-17 2:28 ` john stultz
2008-01-17 2:40 ` Mathieu Desnoyers
2008-01-17 2:50 ` Mathieu Desnoyers
2008-01-17 3:02 ` Steven Rostedt
2008-01-17 3:21 ` Paul Mackerras
2008-01-17 3:39 ` Steven Rostedt
2008-01-17 4:22 ` Mathieu Desnoyers
2008-01-17 4:25 ` Mathieu Desnoyers
2008-01-17 4:14 ` Mathieu Desnoyers
2008-01-17 15:22 ` Steven Rostedt
2008-01-17 17:46 ` Linus Torvalds
2008-01-17 2:51 ` Steven Rostedt
2008-01-16 23:39 ` Mathieu Desnoyers
2008-01-16 23:50 ` Steven Rostedt
2008-01-17 0:36 ` Steven Rostedt
2008-01-17 0:33 ` john stultz
2008-01-17 2:20 ` Mathieu Desnoyers
2008-01-17 1:03 ` Linus Torvalds
2008-01-17 1:35 ` Mathieu Desnoyers
2008-01-17 2:20 ` john stultz
2008-01-17 2:35 ` Mathieu Desnoyers
2008-01-09 23:29 ` [RFC PATCH 17/22 -v2] Add timestamps to tracer Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 18/22 -v2] Sort trace by timestamp Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 19/22 -v2] speed up the output of the tracer Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 20/22 -v2] Add latency_trace format tor tracer Steven Rostedt
2008-01-10 3:41 ` Daniel Walker
2008-01-09 23:29 ` [RFC PATCH 21/22 -v2] Split out specific tracing functions Steven Rostedt
2008-01-09 23:29 ` [RFC PATCH 22/22 -v2] Trace irq disabled critical timings Steven Rostedt
2008-01-10 3:58 ` Daniel Walker
2008-01-10 14:45 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109233043.337688449@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=fche@redhat.com \
--cc=ghaskins@novell.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox