Re: [PATCH] [MEMSTICK] Updates for the memstick driver

Andrew Morton
2008-01-27T06:02:44Z

> On Thu, 24 Jan 2008 23:58:52 -0800 (PST) Alex Dubov <oakad@yahoo.com> wrote:
> * Mark shared inline functions as static
>
> * Use member-at-a-time assignment for protocol structures
>
> * Comments for publicly exported functions
>
> * Use end_queued_request to end unhandled block layer requests
>
> * Use sysfs attribute group to export MSPro attributes
>
> * Fix includes
>
> * Use scnprintf instead of snprintf where string length matters
>
> * Remove spurious get_device/put_device in probe method
>

Please sign off your patches.

Please don't send wordwrapped patches.

Please put the subsystem identifier "memstick" outside [], for reasons
described in http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Your patch contained a fix which I already merged into -mm, which suggests
that you haven't been testing the code in 2.6.24-rc8-mm1. Please do test
-mm when you have patches in there, so that we know that we'll be merging
things which work.

Thanks.