From: Vivek Goyal <vgoyal@redhat.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Horms <horms@verge.net.au>,
magnus.damn@gmail.com
Subject: Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C
Date: Wed, 9 Jan 2008 20:05:31 -0500 [thread overview]
Message-ID: <20080110010531.GA23143@redhat.com> (raw)
In-Reply-To: <1199847470.8126.16.camel@caritas-dev.intel.com>
On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote:
> This patch transforms the kexec page tables setup code from asseumbler
> code to iC code in machine_kexec_prepare. This improves readability and
> reduces code line number.
>
I think this will create issues for Xen. Initially page table setup
was in C but Xen Guests could not modify the page tables. I think Xen
folks implemented a hypercall where they passed all the page table pages
and the control pages and then hypervisor executed the control page(which
in turn setup the page tables). I think that's why page table setup
code is on the control page in assembly.
You might want to go through Xen kexec implementation and dig through
kexec mailing list archive.
CCing Magnus and Horms. They had done the page tables related changes
for Xen.
Thanks
Vivek
next prev parent reply other threads:[~2008-01-10 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 2:57 [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C Huang, Ying
2008-01-10 1:05 ` Vivek Goyal [this message]
2008-01-10 2:08 ` Huang, Ying
2008-01-10 7:21 ` Simon Horman
2008-01-14 13:29 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110010531.GA23143@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damn@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox