public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@phunq.net>
To: Alasdair G Kergon <agk@redhat.com>
Cc: Matt Mackall <mpm@selenic.com>,
	Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	gorcunov@gmail.com
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Date: Thu, 10 Jan 2008 01:49:15 -0800	[thread overview]
Message-ID: <200801100149.16301.phillips@phunq.net> (raw)
In-Reply-To: <20080109224026.GA4039@agk.fab.redhat.com>

Hi Alasdair,

On Wednesday 09 January 2008 14:40, Alasdair G Kergon wrote:
> Device-mapper for example in dm_blk_ioctl(), has no need for BKL so
> drops it immediately, but it does need the inode parameter, so it is
> unable to switch as things stand.

So what stops you from changing to unlocked_ioctl for the main device 
mapper ctl_ioctl?  You aren't using the inode parameter, or the file 
parameter:

   http://lxr.linux.no/linux+v2.6.23.12/drivers/md/dm-ioctl.c#L1402

Regards,

Daniel

  parent reply	other threads:[~2008-01-10  9:49 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 16:40 [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Andi Kleen
2008-01-08 17:05 ` Cyrill Gorcunov
2008-01-08 18:52 ` Alexey Dobriyan
2008-01-08 19:18   ` Andi Kleen
2008-01-09  0:40     ` Arnd Bergmann
2008-01-09  0:47       ` Andi Kleen
2008-01-09  1:19         ` Arnd Bergmann
2008-01-09  1:31           ` Kevin Winchester
2008-01-09  1:41             ` Andi Kleen
2008-01-09  8:02               ` Christoph Hellwig
2008-01-09 10:00         ` Junio C Hamano
     [not found]           ` <200801091255.02172.arnd@arndb.de>
2008-01-09 14:06             ` Andi Kleen
2008-01-08 19:58 ` Paolo Ciarrocchi
2008-01-08 20:00   ` Matthew Wilcox
2008-01-08 20:03     ` Paolo Ciarrocchi
2008-01-08 20:16       ` Matthew Wilcox
2008-01-08 20:21         ` Matthew Wilcox
2008-01-08 20:26           ` Paolo Ciarrocchi
2008-01-08 23:55           ` Dmitri Vorobiev
2008-03-06 14:54       ` supervising, text processing, semantic "patching" (Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl) Oleg Verych
2008-01-08 20:22   ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Rik van Riel
2008-01-08 20:42   ` Andi Kleen
2008-01-08 20:45     ` Paolo Ciarrocchi
2008-01-08 23:06     ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl II Andi Kleen
2008-01-08 23:43       ` Paolo Ciarrocchi
2008-01-09  0:03         ` Andi Kleen
2008-01-09 20:12   ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Matt Mackall
2008-01-09 22:40     ` Alasdair G Kergon
2008-01-09 22:46       ` Andi Kleen
2008-01-09 22:45         ` Alasdair G Kergon
2008-01-09 22:58           ` Chris Friesen
2008-01-09 23:05             ` Alasdair G Kergon
2008-01-09 23:31               ` Vadim Lobanov
2008-01-10  0:00                 ` Alasdair G Kergon
2008-01-10  4:59                   ` Vadim Lobanov
2008-01-10  8:34           ` Christoph Hellwig
2008-01-10  9:49       ` Daniel Phillips [this message]
2008-01-10 11:39         ` Alasdair G Kergon
2008-01-10 22:55           ` Daniel Phillips
2008-01-11  8:33   ` Pavel Machek
2008-01-08 23:50 ` Kevin Winchester
2008-01-09  0:09   ` Andi Kleen
2008-01-09  0:17     ` Kevin Winchester
2008-01-09  0:27       ` Andi Kleen
2008-01-09 10:34 ` Andre Noll
2008-01-09 13:17   ` Richard Knutsson
2008-01-09 13:33     ` Andre Noll
2008-01-10  8:52 ` Rolf Eike Beer
2008-01-10  9:25   ` Andi Kleen
2008-01-10 10:02     ` Rolf Eike Beer
2008-01-10 10:06       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801100149.16301.phillips@phunq.net \
    --to=phillips@phunq.net \
    --cc=agk@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=gorcunov@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=paolo.ciarrocchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox