Re: [PATCH][RFC] fast file mapping for loop

Daniel Phillips
2008-01-11T18:17:48Z

Hi Jens,

This looks really useful.

On Wednesday 09 January 2008 00:52, Jens Axboe wrote:
> Disadvantages:
>
> - The file block mappings must not change while loop is using the
> file. This means that we have to ensure exclusive access to the file
> and this is the bit that is currently missing in the implementation.
> It would be nice if we could just do this via open(), ideas
> welcome...

Get_block methods are pretty fast and you have caching in the level
above you, so you might be able to get away with no cache of physical
addresses at all, in which case you just need i_mutex and i_alloc_sem
at get_block time. This would save a pile of code and still have the
main benefit of avoiding double caching.

If you use ->get_block instead of bmap, it will fill in file holes for
you, but of course get_block is not exposed, and Al is likely to bark
at anyone who exposes it.

Instead of exposing get_block you could expose an aops method
like ->bio_transfer that would hide the use of *_get_block in a library
routine, just as __blockdev_direct_IO does. Chances are, there are
other users besides loop that would be interested in a generic way of
performing bio transfers to files.

I presume you would fall back to the existing approach for any
filesystem without get_block. You could handle this transparently with
a default library method that does read/write.

Regards,

Daniel