Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Andi Kleen
2008-01-09T22:43:39Z

On Wed, Jan 09, 2008 at 10:40:26PM +0000, Alasdair G Kergon wrote:
> On Wed, Jan 09, 2008 at 02:12:40PM -0600, Matt Mackall wrote:
> > You'll need to change the prototype, the unlocked version doesn't take
> > an inode. And you'll need to make sure that nothing in the function uses
> > the inode, which I think Andi forgot to mention.
>
> This old chestnut again. Perhaps we could have inode passed to unlocked_ioctl?
> I never understood why it wasn't there in the first place if the plan was for
> .unlocked_ioctl to supercede .ioctl whenever possible.

If you still need inode use

struct inode *inode = file->f_dentry->d_inode;

-Andi