From: Andi Kleen <andi@firstfloor.org>
To: Andre Noll <maan@systemlinux.org>
Cc: Andi Kleen <andi@firstfloor.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl
Date: Thu, 10 Jan 2008 20:29:50 +0100 [thread overview]
Message-ID: <20080110192950.GG747@one.firstfloor.org> (raw)
In-Reply-To: <20080110190748.GA20152@skl-net.de>
On Thu, Jan 10, 2008 at 08:07:48PM +0100, Andre Noll wrote:
> On 19:59, Andi Kleen wrote:
>
> > But perhaps for such a long ioctl handler it would be better to move
> > the lock/unlock_kernel()s into the individual case ...: statements;
> > then it could be eliminated step by step.
>
> Sure, I can do that if James likes the idea. Since not all case
> statements need the BKL, we could add it only to those for which it
> isn't clear that it is unnecessary.
>
> And this would actually improve something.
I still think it would be a good strategy to first add it to all
(in a essentially nop semantics patch) and then later eliminate
it from the cases that obviously don't need it.
But yes eliminating it from all is the long term goal.
-Andi
next prev parent reply other threads:[~2008-01-10 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 18:05 [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl Andre Noll
2008-01-10 18:54 ` James Bottomley
2008-01-10 18:59 ` Andi Kleen
2008-01-10 19:03 ` Matthew Wilcox
2008-01-10 19:21 ` Andi Kleen
2008-01-10 19:03 ` James Bottomley
2008-01-10 19:32 ` Andi Kleen
2008-01-10 19:33 ` Matthew Wilcox
2008-01-10 19:38 ` Andi Kleen
2008-01-10 19:07 ` Andre Noll
2008-01-10 19:29 ` Andi Kleen [this message]
2008-01-10 19:45 ` Andre Noll
2008-01-10 20:09 ` James Bottomley
2008-01-10 20:13 ` Boaz Harrosh
2008-01-10 20:40 ` Andre Noll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110192950.GG747@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maan@systemlinux.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox