* [PATCH 2/2] checkstack: fix perl warnings
[not found] <20080114111602.591fe1a4@deepthought>
@ 2008-01-14 19:19 ` Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2008-01-14 19:19 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: linux-kernel
If you enable perl warnings on this script, it shows a couple of problems:
Parentheses missing around "my" list at scripts/checkstack.pl line 105.
Useless use of a variable in void context at scripts/checkstack.pl line 105.
Use of uninitialized value in string eq at scripts/checkstack.pl line 33.
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
--- a/scripts/checkstack.pl 2008-01-14 11:10:57.000000000 -0800
+++ b/scripts/checkstack.pl 2008-01-14 11:11:56.000000000 -0800
@@ -30,7 +30,7 @@
my (@stack, $re, $x, $xs);
{
my $arch = shift;
- if ($arch eq "") {
+ if (! defined $arch) {
$arch = `uname -m`;
chomp $arch;
}
@@ -102,7 +102,8 @@ sub bysize($) {
#
my $funcre = qr/^$x* <(.*)>:$/;
my $func;
-my $file, $lastslash;
+my $file;
+my $lastslash;
while (my $line = <STDIN>) {
if ($line =~ m/$funcre/) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-01-14 19:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080114111602.591fe1a4@deepthought>
2008-01-14 19:19 ` [PATCH 2/2] checkstack: fix perl warnings Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox