From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] checkstack: parse architecture correctly
Date: Mon, 14 Jan 2008 11:19:58 -0800 [thread overview]
Message-ID: <20080114111958.58355143@deepthought> (raw)
The checkstack script wouldn't work because it was picking up the
newline on the end of the output of uname -m.
Also, use a standard perl construct to print error message and
exit with non-zero error code.
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
--- a/scripts/checkstack.pl 2008-01-14 11:09:09.000000000 -0800
+++ b/scripts/checkstack.pl 2008-01-14 11:09:51.000000000 -0800
@@ -32,6 +32,7 @@ my (@stack, $re, $x, $xs);
my $arch = shift;
if ($arch eq "") {
$arch = `uname -m`;
+ chomp $arch;
}
$x = "[0-9a-f]"; # hex character
@@ -85,8 +86,7 @@ my (@stack, $re, $x, $xs);
# 0: 00 e8 38 01 LINK 0x4e0;
$re = qr/.*[[:space:]]LINK[[:space:]]*(0x$x{1,8})/o;
} else {
- print("wrong or unknown architecture\n");
- exit
+ die "wrong or unknown architecture\"$arch\"\n";
}
}
next reply other threads:[~2008-01-14 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 19:19 Stephen Hemminger [this message]
2008-01-14 19:50 ` [PATCH 1/2] checkstack: parse architecture correctly Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114111958.58355143@deepthought \
--to=stephen.hemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox