From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Dmitry Torokhov <dtor@mail.ru>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
Liam Girdwood <liam.girdwood@wolfsonmicro.com>,
Graeme Gregory <gg@opensource.wolfsonmicro.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Russell King <rmk@arm.linux.org.uk>, Ian Molton <spyro@f2s.com>,
Vince Sanders <vince@kyllikki.org>,
Andrew Zabolotny <zap@homelink.ru>
Subject: Re: [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode on PXA2xx systems
Date: Mon, 14 Jan 2008 14:42:50 +0000 [thread overview]
Message-ID: <20080114144250.GA7443@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <478B31B6.3050406@pengutronix.de>
On Mon, Jan 14, 2008 at 10:56:06AM +0100, Marc Kleine-Budde wrote:
> reMark Brown wrote:
> > Cc: Marc Kleine-Budde <mkl@penugtronix.de>
> ^^
> it's mkl@pengutronix.de
Fixed, sorry about that.
> > + /* use PEN_DOWN GPIO 13 to assert IRQ on GPIO line 2 */
> > + wm->pen_irq = MAINSTONE_AC97_IRQ;
> I'm missing some kind of abstraction here, what about non mainstone
> boards with the pen irq wired to some other gpio?
The driver really isn't intended to cope with them. As you say, other
boards may have things wired up differently and therefore require
different configuration of the wm97xx and other bits of the system. The
expectation is that other systems will have their own driver.
My initial thought is that the most straightforward way of handling this
would be to rename the driver to mainstone-wm97xx or similar to make it
clear that the driver is only intended to handle Mainstone as-is. Does
that seem reasonable?
next prev parent reply other threads:[~2008-01-14 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 11:51 [PATCH 1/6] Core driver for WM97xx touchscreens Mark Brown
2008-01-10 11:51 ` [PATCH 2/6] Add chip driver for WM9705 touchscreen Mark Brown
2008-01-10 11:51 ` [PATCH 3/6] Add chip driver for WM9712 touchscreen Mark Brown
2008-01-10 11:51 ` [PATCH 4/6] Add chip driver for WM9713 touchscreen Mark Brown
2008-01-10 11:51 ` [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode on PXA2xx systems Mark Brown
2008-01-10 11:51 ` [PATCH 6/6] Build system and MAINTAINERS entry for WM97xx touchscreen drivers Mark Brown
2008-01-10 15:41 ` Sam Ravnborg
2008-01-10 16:00 ` Mark Brown
2008-01-14 9:56 ` [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode on PXA2xx systems Marc Kleine-Budde
2008-01-14 14:42 ` Mark Brown [this message]
2008-01-14 15:06 ` Marc Kleine-Budde
2008-01-14 16:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114144250.GA7443@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dtor@mail.ru \
--cc=gg@opensource.wolfsonmicro.com \
--cc=giometti@enneenne.com \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=rmk@arm.linux.org.uk \
--cc=spyro@f2s.com \
--cc=vince@kyllikki.org \
--cc=zap@homelink.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox