From: Andy Whitcroft <apw@shadowen.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: EXPORTS_SYMBOLs that are in assembly?
Date: Mon, 14 Jan 2008 19:25:07 +0000 [thread overview]
Message-ID: <20080114192507.GC25058@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0801132038410.1764@gandalf.stny.rr.com>
On Sun, Jan 13, 2008 at 08:41:20PM -0500, Steven Rostedt wrote:
>
> Hi guys,
>
> Just wondering what the proper way to export a symbol that is defined in
> assembly? Or is there some kind of annotation I can add in comment form
> that will let checkpatch know the variable is not in C?
>
> Here's what I'm getting:
>
> ./scripts/checkpatch.pl patches/`quilt top`
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its
> function/variable
> #197: FILE: lib/tracing/mcount.c:42:
> +EXPORT_SYMBOL_GPL(mcount);
>
> total: 0 errors, 1 warnings, 316 lines checked
Could you send me a fuller example fragment defining 'foo' as an
example? It is entirly possible you are doing it right and this is an
'ignore checkpatch' situation.
-apw
next prev parent reply other threads:[~2008-01-14 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 1:41 EXPORTS_SYMBOLs that are in assembly? Steven Rostedt
2008-01-14 19:25 ` Andy Whitcroft [this message]
2008-01-15 15:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114192507.GC25058@shadowen.org \
--to=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox