From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754147AbYANTY0 (ORCPT ); Mon, 14 Jan 2008 14:24:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751290AbYANTYS (ORCPT ); Mon, 14 Jan 2008 14:24:18 -0500 Received: from hellhawk.shadowen.org ([80.68.90.175]:4172 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbYANTYS (ORCPT ); Mon, 14 Jan 2008 14:24:18 -0500 Date: Mon, 14 Jan 2008 19:25:07 +0000 From: Andy Whitcroft To: Steven Rostedt Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, LKML Subject: Re: EXPORTS_SYMBOLs that are in assembly? Message-ID: <20080114192507.GC25058@shadowen.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 13, 2008 at 08:41:20PM -0500, Steven Rostedt wrote: > > Hi guys, > > Just wondering what the proper way to export a symbol that is defined in > assembly? Or is there some kind of annotation I can add in comment form > that will let checkpatch know the variable is not in C? > > Here's what I'm getting: > > ./scripts/checkpatch.pl patches/`quilt top` > WARNING: EXPORT_SYMBOL(foo); should immediately follow its > function/variable > #197: FILE: lib/tracing/mcount.c:42: > +EXPORT_SYMBOL_GPL(mcount); > > total: 0 errors, 1 warnings, 316 lines checked Could you send me a fuller example fragment defining 'foo' as an example? It is entirly possible you are doing it right and this is an 'ignore checkpatch' situation. -apw