public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* fs/hfs/btree.c: new NULL dereference
@ 2008-01-14 21:13 Adrian Bunk
  2008-01-14 21:35 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-01-14 21:13 UTC (permalink / raw)
  To: Eric Sandeen, zippel; +Cc: linux-kernel

The Coverity checker spotted the following NULL dereference introduced 
by commit cf0594625083111ae522496dc1c256f7476939c2:

<--  snip  -->

...
struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp keycmp)
{
...
        if (!tree->inode)
                goto free_tree;
...
 free_tree:
        tree->inode->i_mapping->a_ops = &hfs_aops;
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: fs/hfs/btree.c: new NULL dereference
  2008-01-14 21:13 fs/hfs/btree.c: new NULL dereference Adrian Bunk
@ 2008-01-14 21:35 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2008-01-14 21:35 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: zippel, linux-kernel

Adrian Bunk wrote:
> The Coverity checker spotted the following NULL dereference introduced 
> by commit cf0594625083111ae522496dc1c256f7476939c2:

Oops.  Thanks, Adrian.

Patch sent on a different thread, following another fixup patch for
Roman - you're cc'd.

Thanks,

-Eric

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-14 21:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-14 21:13 fs/hfs/btree.c: new NULL dereference Adrian Bunk
2008-01-14 21:35 ` Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox