Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

Bartlomiej Zolnierkiewicz
2008-01-16T22:39:27Z

On Tuesday 15 January 2008, Borislav Petkov wrote:
> On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote:
> > > On Sunday 13 January 2008, Borislav Petkov wrote:
> > > > ..and replace them with flag enums.
> > > >
> > > > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> >
> > small update:
> >
> > PC_ABORT is never set and may as well be removed in a pre-patch
>
> Here you go, the one below should be pushed first...
>
> --
> From: Borislav Petkov <bbpetkov@yahoo.de>
> Date: Tue, 15 Jan 2008 20:34:50 +0100
> Subject: ide-floppy: remove unused flag PC_ABORT
>
> This flag was never being set in the code so remove it. By the way, the
> code in the second patch was being executed unconditionally, i.e. in case
> pc->retries > IDEFLOPPY_MAX_PC_RETRIES is true (actually that is the only case
> when the outer if-test passed), !test_bit(PC_ABORT, &pc->flags)
> was always true so the comment is now incorrect and has to go.
>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

thanks, applied