From: Sam Ravnborg <sam@ravnborg.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mikael Starvik <mikael.starvik@axis.com>,
linux-kernel@vger.kernel.org, Yuusei KUWANA <kuwana@nyanyan.to>
Subject: Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines
Date: Tue, 15 Jan 2008 14:54:19 +0100 [thread overview]
Message-ID: <20080115135419.GA17685@uranus.ravnborg.org> (raw)
In-Reply-To: <20080115133624.GD3912@axis.com>
On Tue, Jan 15, 2008 at 02:36:24PM +0100, Jesper Nilsson wrote:
> - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
> The reservation up to page size of memory after init data was previously
> not done if BLK_DEV_INITRD was undefined.
> This caused a kernel oops when init memory pages were freed after startup,
> data placed in the same page as the last init memory would also be freed
> and reused, with disastrous results.
>
> - Use macros for initcalls and .text sections.
>
> - Replace hardcoded page size constant with PAGE_SIZE define.
>
> - Change include/asm-cris/page.h to use the _AC macro to instead
> of testing __ASSEMBLY__.
Looks good.
What about applying the same fixes/changes to v32?
It would btw. be nice to move the vmlinux.lds.S files to
arch/cris/kernel/.
Se how x86 handle build for two different bit sizes.
If this is done then cris is less awkward compared
to the other archs.
Sam
next prev parent reply other threads:[~2008-01-15 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 13:36 [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines Jesper Nilsson
2008-01-15 13:54 ` Sam Ravnborg [this message]
2008-01-15 14:23 ` Jesper Nilsson
2008-01-15 14:37 ` Sam Ravnborg
2008-01-15 20:35 ` Andrew Morton
2008-01-15 21:02 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115135419.GA17685@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=jesper.nilsson@axis.com \
--cc=kuwana@nyanyan.to \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox