Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

[Jesper Nilsson <jesper.nilsson@axis.com>]

On Tue, Jan 15, 2008 at 02:54:19PM +0100, Sam Ravnborg wrote:
> On Tue, Jan 15, 2008 at 02:36:24PM +0100, Jesper Nilsson wrote:
> > - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
> >   The reservation up to page size of memory after init data was previously
> >   not done if BLK_DEV_INITRD was undefined.
> >   This caused a kernel oops when init memory pages were freed after startup,
> >   data placed in the same page as the last init memory would also be freed
> >   and reused, with disastrous results.
> > 
> > - Use macros for initcalls and .text sections.
> > 
> > - Replace hardcoded page size constant with PAGE_SIZE define.
> > 
> > - Change include/asm-cris/page.h to use the _AC macro to instead
> >   of testing __ASSEMBLY__.
> 
> Looks good.

Thanks.

> What about applying the same fixes/changes to v32?

In the works.

> It would btw. be nice to move the vmlinux.lds.S files to
> arch/cris/kernel/.
> Se how x86 handle build for two different bit sizes.
> 
> If this is done then cris is less awkward compared
> to the other archs.

That's a really good idea. I'll add that to my todo-list.

> 	Sam

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- jesper.nilsson@axis.com