Re: [PATCH 3/4] printk: implement merging printk

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 16 Jan 2008 10:00:09 +0900 Tejun Heo wrote:


> ---
>  include/linux/kernel.h |   71 ++++++++++++++++
>  kernel/printk.c        |  215 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 286 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index ade3ac9..f92a4a1 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -175,6 +175,29 @@ extern struct pid *session_of_pgrp(struct pid *pgrp);
>  extern void dump_thread(struct pt_regs *regs, struct user *dump);
>  
>  #ifdef CONFIG_PRINTK
> +struct mprintk {
> +	char *		header;
> +	char *		body;
> +	char *		cur;
> +	char *		prv;
> +	char *		end;

We aren't very consistent about this, but I think that we would prefer

	char		*header;

etc. there.


> +	int		overflowed;
> +};
> +
> +#define MPRINTK_INITIALIZER(_buf, _size)				\
> +	{								\
> +		.header		= NULL,					\
> +		.body		= _buf,					\
> +		.cur		= _buf,					\
> +		.prv		= NULL,					\
> +		.end		= _buf + _size,				\
> +		.overflowed	= 0,					\
> +	}
> +
> +#define DEFINE_MPRINTK(name, size)					\
> +	char __##name##_buf[size];					\
> +	struct mprintk name = MPRINTK_INITIALIZER(__##name##_buf, size)

---
~Randy