From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbYAOTvR (ORCPT ); Tue, 15 Jan 2008 14:51:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751618AbYAOTvB (ORCPT ); Tue, 15 Jan 2008 14:51:01 -0500 Received: from tomts13-srv.bellnexxia.net ([209.226.175.34]:37255 "EHLO tomts13-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbYAOTvB (ORCPT ); Tue, 15 Jan 2008 14:51:01 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4HAK+djEdMROHU/2dsb2JhbACBWKoy Date: Tue, 15 Jan 2008 14:50:57 -0500 From: Mathieu Desnoyers To: Sam Ravnborg Cc: Linus Torvalds , Russell King , Adrian Bunk , Andrew Morton , Randy Dunlap , phil.el@wanadoo.fr, oprofile-list@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support Message-ID: <20080115195057.GA14152@Krystal> References: <20071228195841.GA3945@flint.arm.linux.org.uk> <20080115104526.GA32067@flint.arm.linux.org.uk> <20080115173701.GB8375@Krystal> <20080115190719.GA12236@Krystal> <20080115191623.GA19694@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20080115191623.GA19694@uranus.ravnborg.org> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 14:47:58 up 73 days, 53 min, 4 users, load average: 0.46, 0.78, 0.87 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sam Ravnborg (sam@ravnborg.org) wrote: > On Tue, Jan 15, 2008 at 02:07:20PM -0500, Mathieu Desnoyers wrote: > > * Linus Torvalds (torvalds@linux-foundation.org) wrote: > > > > > > > > > On Tue, 15 Jan 2008, Mathieu Desnoyers wrote: > > > > > > > > Well, it goes along the lines of the patch I suggested as a reply to > > > > Adrian, with these differences : > > > > > > > > - I still source the kernel/Kconfig.instrumentation file. > > > > - I put back the missing OPROFILE options directly in arch/arm/Kconfig > > > > > > > > Then end result is the same as your patch, but without the code > > > > duplication. > > > > > > No it's not. > > > > > > Now the config variables may all be there, but the UI for the *menu* > > > system is broken (ie all the ARM profiling config options are now outside > > > the profiling menu). > > > > > > Is that menu really needed? I dunno. But since it exists, it should be > > > correct. > > > > > > Linus > > > > There is an "instrumentation menu removal" patchset I've submitted to > > Andrew for the next release cycle that moves the instrumentation menu > > content into General setup (I did this following your advice). > > > > Furthermore, on ARM, the OPROFILE_ARMV6, OPROFILE_MPCORE and > > OPROFILE_ARM11_CORE are all "bool , default y" (equivalent to the > > preferred def_bool y). Unless I am grossly mistaken, this is not > > supposed to show up in the menus; it's just selected when the > > dependencies are met. > > This was the patch: > +if OPROFILE > + > +config OPROFILE_ARMV6 > + def_bool y > + depends on CPU_V6 && !SMP > + select OPROFILE_ARM11_CORE > + > +config OPROFILE_MPCORE > + def_bool y > + depends on CPU_V6 && SMP > + select OPROFILE_ARM11_CORE > + > +config OPROFILE_ARM11_CORE > + bool > + > +endif > > And none of these has a prompt defined so they do not show up > as a menu. > It is very easy to test if you have the patch applied. > No cross toolchin is needed - just do: > make ARCH=arm menuconfig > > Sam Just tested with and without oprofile/MPCORE/CPU_V6 combinations and I confirm that : - no menu is showing up (as expected) - the OPROFILE_* config options are selected (or not) as expected Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68