From: venkatesh.pallipadi@intel.com
To: ak@muc.de, ebiederm@xmission.com, rdreier@cisco.com,
torvalds@linux-foundation.org, gregkh@suse.de, airlied@skynet.ie,
davej@redhat.com, mingo@elte.hu, tglx@linutronix.de,
hpa@zytor.com, akpm@linux-foundation.org, arjan@infradead.org,
jesse.barnes@intel.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [patch 2/4] x86: PAT followup - Remove KERNPG_TABLE from pte entry
Date: Tue, 15 Jan 2008 18:39:57 -0800 [thread overview]
Message-ID: <20080116024111.825025000@intel.com> (raw)
In-Reply-To: 20080116023955.597433000@intel.com
[-- Attachment #1: remove_pgtable_flags.patch --]
[-- Type: text/plain, Size: 1075 bytes --]
KERNPG_TABLE was a bug in earlier patch. Remove it from pte.
pte_val() check is redundant as this routine is called immediately after a
ptepage is allocated afresh.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Index: linux-2.6.git/arch/x86/mm/init_64.c
===================================================================
--- linux-2.6.git.orig/arch/x86/mm/init_64.c 2008-01-15 11:02:23.000000000 -0800
+++ linux-2.6.git/arch/x86/mm/init_64.c 2008-01-15 11:06:37.000000000 -0800
@@ -541,9 +541,6 @@
if (address >= end)
break;
- if (pte_val(*pte))
- continue;
-
/* Nothing to map. Map the null page */
if (!(address & (~PAGE_MASK)) &&
(address + PAGE_SIZE <= end) &&
@@ -561,9 +558,9 @@
}
if (exec)
- entry = _PAGE_NX|_KERNPG_TABLE|_PAGE_GLOBAL|address;
+ entry = _PAGE_NX|_PAGE_GLOBAL|address;
else
- entry = _KERNPG_TABLE|_PAGE_GLOBAL|address;
+ entry = _PAGE_GLOBAL|address;
entry &= __supported_pte_mask;
set_pte(pte, __pte(entry));
}
--
next prev parent reply other threads:[~2008-01-16 2:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 2:39 [patch 0/4] x86: PAT followup - Incremental changes and bug fixes venkatesh.pallipadi
2008-01-16 2:39 ` [patch 1/4] x86: PAT followup - Do not fold two bits in _PAGE_PCD venkatesh.pallipadi
2008-01-16 2:39 ` venkatesh.pallipadi [this message]
2008-01-16 8:14 ` [patch 2/4] x86: PAT followup - Remove KERNPG_TABLE from pte entry Mika Penttilä
2008-01-16 18:17 ` Pallipadi, Venkatesh
2008-01-17 0:18 ` Venki Pallipadi
2008-01-16 2:39 ` [patch 3/4] x86: PAT followup - Remove reserved pages mapping to zero page and not map them venkatesh.pallipadi
2008-01-16 2:39 ` [patch 4/4] x86: PAT followup - use ioremap for devmem read of reserved regions venkatesh.pallipadi
2008-01-16 7:33 ` Ingo Molnar
2008-01-16 7:29 ` [patch 0/4] x86: PAT followup - Incremental changes and bug fixes Ingo Molnar
2008-01-16 18:57 ` Andreas Herrmann
2008-01-16 19:05 ` Pallipadi, Venkatesh
2008-01-16 19:37 ` Pallipadi, Venkatesh
2008-01-16 20:24 ` Ingo Molnar
2008-01-16 20:33 ` Venki Pallipadi
2008-01-16 22:01 ` Andi Kleen
2008-01-16 22:14 ` Pallipadi, Venkatesh
2008-01-16 22:29 ` Andi Kleen
2008-01-17 19:12 ` Andreas Herrmann3
2008-01-17 19:54 ` Andreas Herrmann3
2008-01-17 20:36 ` Ingo Molnar
2008-01-17 20:33 ` H. Peter Anvin
2008-01-17 20:56 ` Ingo Molnar
2008-01-17 20:57 ` Linus Torvalds
2008-01-17 20:44 ` Ingo Molnar
2008-01-17 21:03 ` Andreas Herrmann3
2008-01-17 21:13 ` Ingo Molnar
2008-01-17 21:22 ` Ingo Molnar
2008-01-17 21:31 ` Siddha, Suresh B
2008-01-17 21:38 ` H. Peter Anvin
2008-01-24 20:22 ` Eric W. Biederman
2008-01-24 21:36 ` H. Peter Anvin
2008-01-17 21:42 ` Ingo Molnar
2008-01-17 22:06 ` Andreas Herrmann3
2008-01-17 22:05 ` H. Peter Anvin
2008-01-17 22:15 ` Ingo Molnar
2008-01-17 22:52 ` Andreas Herrmann3
2008-01-17 23:04 ` Venki Pallipadi
2008-01-17 23:24 ` Andreas Herrmann3
2008-01-17 23:42 ` Pallipadi, Venkatesh
2008-01-18 16:10 ` Andreas Herrmann3
2008-01-18 17:13 ` Pallipadi, Venkatesh
2008-01-18 17:33 ` Balbir Singh
2008-01-18 4:25 ` Andi Kleen
2008-01-17 21:42 ` Andreas Herrmann3
2008-01-17 22:13 ` Ingo Molnar
2008-01-17 22:16 ` Andreas Herrmann3
2008-01-17 22:26 ` Andreas Herrmann3
2008-01-17 22:35 ` Ingo Molnar
2008-01-17 23:06 ` Andreas Herrmann3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116024111.825025000@intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=airlied@skynet.ie \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox