From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tejun Heo <htejun@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Gabor Gombas <gombasg@sztaki.hu>, Greg KH <greg@kroah.com>,
Dave Young <hidave.darkstar@gmail.com>,
bluez-devel@lists.sourceforge.net
Subject: Re: [PATCH 2.6.24-rc7 2/2] sysfs: fix bugs in sysfs_rename/move_dir()
Date: Wed, 16 Jan 2008 03:52:24 +0000 [thread overview]
Message-ID: <20080116035224.GW27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.1.00.0801151928380.2806@woody.linux-foundation.org>
On Tue, Jan 15, 2008 at 07:41:58PM -0800, Linus Torvalds wrote:
> and wonder what happen sif old_parent == new_parent. Is that trying to
> avoid an ABBA deadlock? Normally you'd do it by ordering the locks, or by
> taking a third lock to guarantee serialization at a higher level (ie the
> "s_vfs_rename_mutex" on the VFS layer)
>
> I'd like to apply these two patches, but I really want to get more of an
> ack for them from somebody like Al, or at least more of an explanation for
> why it's all the right thing.
No ACK is coming until we get something resembling analysis of locking
scheme. Which won't happen until we at least get the "what callers are
allowed to do" written down, damnit. As it is, I'm more than inclined
to propose ripping kobject_move() out, especially since it has only two
users - something s390-specific and rfcomm, with its shitloads of problems
beyond just sysfs interaction.
next prev parent reply other threads:[~2008-01-16 3:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 3:06 [PATCH 2.6.24-rc7 1/2] sysfs: make sysfs_lookup() return ERR_PTR(-ENOENT) on failed lookup Tejun Heo
2008-01-16 3:10 ` [PATCH 2.6.24-rc7 2/2] sysfs: fix bugs in sysfs_rename/move_dir() Tejun Heo
2008-01-16 3:41 ` Linus Torvalds
2008-01-16 3:52 ` Al Viro [this message]
2008-01-16 7:23 ` Tejun Heo
2008-01-17 4:22 ` Al Viro
2008-01-16 6:47 ` Tejun Heo
2008-01-16 8:20 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116035224.GW27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bluez-devel@lists.sourceforge.net \
--cc=gombasg@sztaki.hu \
--cc=greg@kroah.com \
--cc=hidave.darkstar@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox