Re: [PATCH] kprobe: missing cast

[Ananth N Mavinakayanahalli <ananth@in.ibm.com>]

On Mon, Jan 14, 2008 at 07:21:55PM -0800, Stephen Hemminger wrote:
> Fix warning from missing cast, maybe a result of the x86 merge?
> 
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>

Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

Thanks Stephen!

Ananth

> 
>   CC      arch/x86/kernel/kprobes_32.o
> arch/x86/kernel/kprobes_32.c: In function ‘longjmp_break_handler’:
> arch/x86/kernel/kprobes_32.c:729: warning: comparison of distinct pointer types lacks a cast
> 
> --- a/arch/x86/kernel/kprobes_32.c	2008-01-14 19:18:01.000000000 -0800
> +++ b/arch/x86/kernel/kprobes_32.c	2008-01-14 19:18:08.000000000 -0800
> @@ -726,7 +726,7 @@ int __kprobes longjmp_break_handler(stru
>  	struct jprobe *jp = container_of(p, struct jprobe, kp);
>  
>  	if ((addr > (u8 *) jprobe_return) && (addr < (u8 *) jprobe_return_end)) {
> -		if (&regs->esp != kcb->jprobe_saved_esp) {
> +		if ((unsigned long *) &regs->esp != kcb->jprobe_saved_esp) {
>  			struct pt_regs *saved_regs = &kcb->jprobe_saved_regs;
>  			printk("current esp %p does not match saved esp %p\n",
>  			       &regs->esp, kcb->jprobe_saved_esp);