From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 2/2] 8250_pnp: register x86 COM ports at the conventional ttyS names
Date: Wed, 16 Jan 2008 18:42:06 +0000 [thread overview]
Message-ID: <20080116184206.GC23371@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080116170914.959390017@ldl.fc.hp.com>
On Wed, Jan 16, 2008 at 10:05:43AM -0700, Bjorn Helgaas wrote:
> static int __devinit
> +serial_pnp_line(struct uart_port *port)
> +{
> +#ifdef CONFIG_X86
> + switch (port->iobase) {
> + case 0x3f8: return 0; /* COM1 -> ttyS0 */
> + case 0x2f8: return 1; /* COM2 -> ttyS1 */
> + case 0x3e8: return 2; /* COM3 -> ttyS2 */
> + case 0x2e8: return 3; /* COM4 -> ttyS3 */
> + }
> +#endif
So what if someone intentionally modifies SERIAL_DEFN_PORTS to point
ttyS[0-3] somewhere else? They also have to modify this code as well.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-01-16 18:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 17:05 [patch 0/2] serial: explicitly request ttyS0-3 for COM1-4 Bjorn Helgaas
2008-01-16 17:05 ` [patch 1/2] 8250: add serial8250_register_port_at() for requesting specific ttyS lines Bjorn Helgaas
2008-01-16 17:05 ` [patch 2/2] 8250_pnp: register x86 COM ports at the conventional ttyS names Bjorn Helgaas
2008-01-16 18:42 ` Russell King [this message]
2008-01-16 18:44 ` H. Peter Anvin
2008-01-16 19:47 ` Bjorn Helgaas
2008-01-16 19:49 ` H. Peter Anvin
2008-01-16 18:39 ` [patch 0/2] serial: explicitly request ttyS0-3 for COM1-4 Russell King
2008-01-16 19:59 ` Bjorn Helgaas
2008-01-16 20:14 ` Russell King
2008-01-17 16:07 ` Bjorn Helgaas
2008-01-17 16:16 ` Russell King
2008-01-17 17:56 ` Bjorn Helgaas
[not found] <9MjWa-VI-9@gated-at.bofh.it>
[not found] ` <9MjWb-VI-11@gated-at.bofh.it>
[not found] ` <9MlEG-3Mx-13@gated-at.bofh.it>
[not found] ` <9Mmra-56f-29@gated-at.bofh.it>
2008-01-16 20:33 ` [patch 2/2] 8250_pnp: register x86 COM ports at the conventional ttyS names Bodo Eggert
2008-01-16 20:42 ` H. Peter Anvin
2008-01-16 23:34 ` Rene Herman
2008-01-18 18:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116184206.GC23371@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox