From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
ak@suse.de
Subject: Re: [PATCH] x86: fix detection of CONSTANT_TSC bit for AMD CPUs
Date: Wed, 16 Jan 2008 21:28:20 +0100 [thread overview]
Message-ID: <20080116202820.GA6016@elte.hu> (raw)
In-Reply-To: <20080116194606.GB11244@alberich.amd.com>
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> Commits
> - c52f61fcbdb2aa84f0e4d831ef07f375e6b99b2c
> (x86: allow TSC clock source on AMD Fam10h and some cleanup)
> - e30436f05d456efaff77611e4494f607b14c2782
> (x86: move X86_FEATURE_CONSTANT_TSC into early cpu feature detection)
>
> are supposed to fix the detection of contant TSC for AMD CPUs.
> Unfortunately on x86_64 it does still not work with current x86/mm.
> For a Phenom I still get:
>
> ...
> TSC calibrated against PM_TIMER
> Marking TSC unstable due to TSCs unsynchronized
> time.c: Detected 2288.366 MHz processor.
> ...
>
> We have to set c->x86_power in early_identify_cpu to properly detect
> the CONSTANT_TSC bit in early_init_amd.
>
> Attached patch fixes this issue. Following the relevant boot
> messages when the fix is used:
>
> ...
> TSC calibrated against PM_TIMER
> time.c: Detected 2288.279 MHz processor.
> ...
> Initializing CPU#1
> ...
> checking TSC synchronization [CPU#0 -> CPU#1]: passed.
> ...
> Initializing CPU#2
> ...
> checking TSC synchronization [CPU#0 -> CPU#2]: passed.
> ...
> Booting processor 3/4 APIC 0x3
> ...
> checking TSC synchronization [CPU#0 -> CPU#3]: passed.
> Brought up 4 CPUs
> ...
>
> Patch is against x86/mm (v2.6.24-rc8-672-ga9f7faa).
> Please apply.
thanks, applied.
Ingo
next prev parent reply other threads:[~2008-01-16 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 19:46 [PATCH] x86: fix detection of CONSTANT_TSC bit for AMD CPUs Andreas Herrmann
2008-01-16 20:28 ` Ingo Molnar [this message]
2008-01-16 20:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116202820.GA6016@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox