From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757631AbYAQUoG (ORCPT ); Thu, 17 Jan 2008 15:44:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757305AbYAQUno (ORCPT ); Thu, 17 Jan 2008 15:43:44 -0500 Received: from hera.kernel.org ([140.211.167.34]:58498 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757238AbYAQUnm (ORCPT ); Thu, 17 Jan 2008 15:43:42 -0500 From: Len Brown Organization: Intel Open Source Technology Center To: Randy Dunlap Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver Date: Thu, 17 Jan 2008 14:51:18 -0500 User-Agent: KMail/1.9.5 Cc: Zhang Rui , linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sujith.thomas@intel.com References: <1200556278.2935.118.camel@acpi-sony.sh.intel.com> <20080117092030.a9dfe528.randy.dunlap@oracle.com> In-Reply-To: <20080117092030.a9dfe528.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801171451.18613.lenb@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +static int > > +memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev, > > + unsigned long *max_state) > > Don't put 'static int' (return type etc.) on a line by itself. > That format is not wanted in Linux. (many places here) if checkpatch.pl and Lindent are happey (which they are not, totally) then I'm satisifed witht he Linux style of the code. Randy, if you feel strongly about this this style nit, then change Lindent to implement it -- nagging developers about trivia is a waste of everybody's time. thanks, -Len