From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: copy srat table and unmap in acpi_parse_table
Date: Thu, 17 Jan 2008 23:06:38 +0100 [thread overview]
Message-ID: <20080117220638.GA18883@elte.hu> (raw)
In-Reply-To: <200801171409.56611.yinghai.lu@sun.com>
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> > Or if d8d28f25f33c6a03 really needs to be reverted to get your
> > system to boot properly, which particular bit of it was causing
> > trouble for you? (or the whole thing?)
>
> we need to call acpi_os_unmap_memory in acpi_table_parse or just after
> it.
>
> call it in acpi_table_parse is much cleaner
agreed - i had a second look at your patch and it's much cleaner.
> the problem is that acpi_numa_slit_init do bad assumaption that it
> still can use address after it's callback function. so we need to copy
> the slit.
ok. I've applied your patch and boot-tested it already - it should show
up soon in the next x86.git drop.
Ingo
prev parent reply other threads:[~2008-01-17 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 20:44 [PATCH] x86: copy srat table and unmap in acpi_parse_table Yinghai Lu
2008-01-17 20:43 ` Ingo Molnar
2008-01-17 22:09 ` Yinghai Lu
2008-01-17 22:06 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080117220638.GA18883@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox