From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, "Thomas,
Sujith" <sujith.thomas@intel.com>
Subject: Re: [PATCH 6/10] ACPI: register ACPI Video LCD as generic thermal cooling device
Date: Fri, 18 Jan 2008 01:42:54 +0000 [thread overview]
Message-ID: <20080118014254.GA14818@srcf.ucam.org> (raw)
In-Reply-To: <1200619900.2935.161.camel@acpi-sony.sh.intel.com>
On Fri, Jan 18, 2008 at 09:31:40AM +0800, Zhang Rui wrote:
> Just like I don't think lcd should be used for ACPI thermal management
> before I saw it is listed in _TZD and intel_menlow requires to throttle
> it when overheating, why not let the individual drivers implement the
> callbacks if there is clearly a request to do this.
> And we can add this to the generic acpi_device struct then if this is a
> common feature for all ACPI devices.
It'll probably never be common for all ACPI devices, but it's already
required for three types. I think that's a strong argument for making it
generic.
> Well, you're right.
> But in order to throttle the lcd, this is reasonable, right?
Moving the common code into its own routine and then calling that from
each of the others would probably work.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-01-18 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 7:51 [PATCH 6/10] ACPI: register ACPI Video LCD as generic thermal cooling device Zhang Rui
2008-01-17 12:24 ` Matthew Garrett
2008-01-18 1:31 ` Zhang Rui
2008-01-18 1:42 ` Matthew Garrett [this message]
2008-01-22 8:01 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118014254.GA14818@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rui.zhang@intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox