public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86_32: remove the useless NR_syscalls macro
@ 2008-01-18  3:41 Dmitri Vorobiev
  2008-01-18  8:13 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitri Vorobiev @ 2008-01-18  3:41 UTC (permalink / raw)
  To: tglx, mingo, hpa; +Cc: Linux-kernel

This is against current x86.git.

The size of the system call table for 32-bit x86 kernels is obtained by
compile-time calculation of the sys_call_table array, not from the value,
which the NR_syscalls macro expands to. This trivial patch removes the
fossil macro.

Manually tested by grepping the x86 files for the "NR_syscalls" string.
No relevant use cases found.

Build-tested using allyesconfig, allnoconfig and a couple of randconfig
instances. All builds successfully finished.

Runtime test performed using a stripped-down Debian-ish config. The system
booted successfully.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 include/asm-x86/unistd_32.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/unistd_32.h b/include/asm-x86/unistd_32.h
index 9b15545..8d8f9b5 100644
--- a/include/asm-x86/unistd_32.h
+++ b/include/asm-x86/unistd_32.h
@@ -333,8 +333,6 @@ #define __NR_fallocate		324
 
 #ifdef __KERNEL__
 
-#define NR_syscalls 325
-
 #define __ARCH_WANT_IPC_PARSE_VERSION
 #define __ARCH_WANT_OLD_READDIR
 #define __ARCH_WANT_OLD_STAT
-- 
1.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86_32: remove the useless NR_syscalls macro
  2008-01-18  3:41 [PATCH] x86_32: remove the useless NR_syscalls macro Dmitri Vorobiev
@ 2008-01-18  8:13 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-01-18  8:13 UTC (permalink / raw)
  To: Dmitri Vorobiev; +Cc: tglx, mingo, hpa, Linux-kernel


* Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:

> This is against current x86.git.
> 
> The size of the system call table for 32-bit x86 kernels is obtained 
> by compile-time calculation of the sys_call_table array, not from the 
> value, which the NR_syscalls macro expands to. This trivial patch 
> removes the fossil macro.
> 
> Manually tested by grepping the x86 files for the "NR_syscalls" 
> string. No relevant use cases found.
> 
> Build-tested using allyesconfig, allnoconfig and a couple of 
> randconfig instances. All builds successfully finished.
> 
> Runtime test performed using a stripped-down Debian-ish config. The 
> system booted successfully.

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-18  8:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-18  3:41 [PATCH] x86_32: remove the useless NR_syscalls macro Dmitri Vorobiev
2008-01-18  8:13 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox