From: Jarek Poplawski <jarkao2@gmail.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, Greg KH <gregkh@suse.de>,
stefanr@s5r6.in-berlin.de, David Brownell <david-b@pacbell.net>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] driver-core : convert semaphore to mutex in struct class
Date: Fri, 18 Jan 2008 09:39:41 +0100 [thread overview]
Message-ID: <20080118083941.GD1703@ff.dom.local> (raw)
In-Reply-To: <20080118080034.GB1703@ff.dom.local>
On Fri, Jan 18, 2008 at 09:00:34AM +0100, Jarek Poplawski wrote:
> On Fri, Jan 18, 2008 at 09:42:25AM +0800, Dave Young wrote:
> ...
> > After digging the class usage code again, I found that the only
> > possible double lock place is the class_interface_register/unregister
> > in which the class_device api could be called.
>
> OK, but currently after using mostly:
> mutex_lock(&parent_class)
>
> and once:
> mutex_lock_nested(&parent_class, SINGLE_DEPTH_NESTING)
>
> lockdep mostly thinks these parent classes are 2 different objects,
> with only 2 possible levels of nesting, so this parent_class has
> to have wrong name (2 parents can't be locked from the same thread,
> so maybe it's class_grandparent sometimes?).
...Hmm... I was probably wrong: this could be right if there are only
two levels of nesting used and class locks it's parent only!
Jarek P.
next prev parent reply other threads:[~2008-01-18 8:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 10:05 [PATCH 7/7] driver-core : convert semaphore to mutex in struct class Dave Young
2008-01-15 9:15 ` Dave Young
2008-01-15 13:56 ` Jarek Poplawski
2008-01-16 1:03 ` Dave Young
2008-01-16 8:34 ` Jarek Poplawski
2008-01-17 1:17 ` Dave Young
2008-01-17 8:38 ` Jarek Poplawski
2008-01-17 8:56 ` Dave Young
2008-01-16 15:27 ` Alan Stern
2008-01-17 0:01 ` Jarek Poplawski
2008-01-17 1:18 ` Dave Young
2008-01-17 15:16 ` Alan Stern
2008-01-17 19:47 ` Jarek Poplawski
2008-01-17 19:57 ` Alan Stern
2008-01-17 20:31 ` Jarek Poplawski
2008-01-17 22:02 ` Jarek Poplawski
2008-01-17 23:26 ` Jarek Poplawski
2008-01-18 1:42 ` Dave Young
2008-01-18 1:55 ` Kay Sievers
2008-01-18 2:28 ` Dave Young
2008-01-18 3:18 ` Kay Sievers
2008-01-18 6:25 ` Greg KH
[not found] ` <a8e1da0801172131h57097622h6d111133b6a0773d@mail.gmail.com>
2008-01-18 7:38 ` Jarek Poplawski
2008-01-18 7:48 ` Dave Young
2008-01-18 8:23 ` Jarek Poplawski
2008-01-18 9:07 ` Dave Young
2008-01-19 9:39 ` Jarek Poplawski
2008-01-21 1:19 ` Dave Young
2008-01-21 1:30 ` Dave Young
2008-01-21 1:43 ` Dave Young
2008-01-21 8:36 ` Jarek Poplawski
2008-01-21 8:44 ` Dave Young
2008-01-21 9:03 ` Jarek Poplawski
2008-01-21 21:16 ` Jarek Poplawski
2008-01-22 0:55 ` Dave Young
2008-01-22 5:15 ` Greg KH
2008-01-22 6:13 ` Dave Young
2008-01-22 7:45 ` Jarek Poplawski
2008-01-18 10:45 ` Kay Sievers
2008-01-18 11:40 ` Jarek Poplawski
2008-01-18 8:00 ` Jarek Poplawski
2008-01-18 8:39 ` Jarek Poplawski [this message]
2008-01-17 21:11 ` Greg KH
2008-01-17 21:55 ` Jarek Poplawski
2008-01-18 1:45 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118083941.GD1703@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox