Re: [PATCH] x86: Use v8086_mode helper, trivial unification

H. Peter Anvin
2008-01-18T01:05:44Z

Harvey Harrison wrote:
>
> Sorry, missed that detail in ptrace.h, I notice now.
>
> Is there some better way this could be organized, would the following
> be an improvement, as opposed to two long ifdef sections?
>
> Patch will follow if you think it's a good idea.

It is actually quite a bit easier to read.

>
> static inline unsigned long stack_pointer(struct pt_regs *regs)
> {
> #ifdef CONFIG_X86_32
> return (unsigned long)regs;
> #else
> return regs->sp;
> #endif
> }

This one is kind of strange. In particular, the 32-bit definition isn't
exactly what one would expect. It makes me concerned that it actually
refers to two different kinds of stack pointers?

> /* still need a define here, as one is long and one is unsigned long.
> * but this is another target for unification I guess. */
> #define regs_return_value(regs) ((regs)->ax)

Indeed...

-hpa